Beam post commit java influx db io it #28530
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Oh neat, I think that's a good addition. If infra doesn't like it, we could also always write our own (its not much code - https://github.com/pyTooling/Actions/blob/main/with-post-step/main.js) @Abacn would you mind following up with infra to request this one? |
| beam_PostCommit_Java_InfluxDbIO_IT: | ||
| name: ${{matrix.job_name}} (${{matrix.job_phrase}}) | ||
| runs-on: [self-hosted, ubuntu-20.04, main] | ||
| timeout-minutes: 120 |
There was a problem hiding this comment.
Since there is no explicitly specified job timeout, it should be 100 by default
| runs-on: [self-hosted, ubuntu-20.04, main] | ||
| timeout-minutes: 120 | ||
| strategy: | ||
| fail-fast: false |
There was a problem hiding this comment.
I think this is redundant since there are no other jobs to run
| job_name: [beam_PostCommit_Java_InfluxDbIO_IT] | ||
| job_phrase: [Run Java InfluxDbIO_IT] | ||
| if: | | ||
| github.event_name == 'push' || |
There was a problem hiding this comment.
Should be removed, since there is no push event listed
| uses: ./.github/actions/setup-k8s-access | ||
| with: | ||
| cluster_name: io-datastores | ||
| k8s_namespace: workflow-${{ github.run_id }} |
There was a problem hiding this comment.
I think it makes sense to include the job name:
k8s_namespace: ${{ matrix.job_name }}-${{ github.run_id }}
There was a problem hiding this comment.
Added and supported in k8s action
| - name: Install InfluxDB | ||
| id: install_influxdb | ||
| run: | | ||
| kubectl apply -f .test-infra/kubernetes/influxdb/influxdb.yml |
There was a problem hiding this comment.
Should we specify the absolute path?
${{ github.workspace }}/.test-infra/kubernetes/influxdb/influxdb.yml
| uses: ./.github/actions/gradle-command-self-hosted-action | ||
| with: | ||
| gradle-command: :sdks:java:io:influxdb:integrationTest --tests org.apache.beam.sdk.io.influxdb.InfluxDbIOIT | ||
| arguments: -DintegrationTestRunner=direct -DintegrationTestPipelineOptions='["--influxDBURL=http://${{ steps.install_influxdb.outputs.influxdb_IP }}:8086","--influxDBUserName=superadmin","--influxDBPassword=supersecretpassword","--databaseName=db1"]' |
There was a problem hiding this comment.
Not sure that this is really necessary, but there is a --info switch that is being used by Jenkins
Sorry for missed the comment. Opened https://issues.apache.org/jira/browse/INFRA-25021 |
|
@damccorm this one is ok now since the action got approved so please take a final look |
Migrate beam_PostCommit_Java_InfluxDbIO_IT
Also adds an action for setting up access for k8s cluster.
Uses pyTooling/Actions/with-post-step@v0.4.6 in order to cleanup the created namespace when the job is finished or failed. Think it will need approval
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.