Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: workflow with a matrix triggered by a phrase show false positive result #28593

Open
15 tasks
Abacn opened this issue Sep 21, 2023 · 1 comment
Open
15 tasks
Labels
bug github_actions Pull requests that update GitHub Actions code P2

Comments

@Abacn
Copy link
Contributor

Abacn commented Sep 21, 2023

What happened?

Currently, some workflow run a matrix of version and phrase triggers also share the same prefix in addition to the version number, e.g. Python PostCommit has phrases

  • Run Python PostCommit 3.8
  • Run Python PostCommit 3.9
  • Run Python PostCommit 3.10
  • Run Python PostCommit 3.11

However, if comment one of this under a PR, the test result will show failure because the workflow skips other element by exit 1 here. There isn't a way to run a full matrix of job from single comment either (like cron job does).

This introduces inconvenience for mass_commit in release verification where the related workflow must be checked manually

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn Abacn added bug awaiting triage github_actions Pull requests that update GitHub Actions code and removed awaiting triage labels Sep 21, 2023
@github-actions github-actions bot added the P2 label Sep 21, 2023
@Abacn Abacn changed the title [Bug]: workflow with a matrix triggered by a phrase show negative false result [Bug]: workflow with a matrix triggered by a phrase show false positive result Sep 21, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Sep 27, 2023

For example,

image

Then it needs to click one-by-one to check the actual status in mass_commit: #28698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug github_actions Pull requests that update GitHub Actions code P2
Projects
None yet
Development

No branches or pull requests

1 participant