Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace StorageV1 client with GCS client (#28079)" #28721

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

damccorm
Copy link
Contributor

This reverts commit 94812c0. This has caused users to report some pipeline failures


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #28721 (8223674) into master (dda0eb9) will increase coverage by 0.28%.
Report is 3 commits behind head on master.
The diff coverage is 75.25%.

@@            Coverage Diff             @@
##           master   #28721      +/-   ##
==========================================
+ Coverage   71.96%   72.24%   +0.28%     
==========================================
  Files         680      684       +4     
  Lines      100172   101241    +1069     
==========================================
+ Hits        72085    73139    +1054     
- Misses      26511    26526      +15     
  Partials     1576     1576              
Flag Coverage Δ
python 82.80% <75.25%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/internal/gcp/auth.py 84.61% <ø> (-0.39%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery_tools.py 75.00% <ø> (ø)
...cp/internal/clients/storage/storage_v1_messages.py 100.00% <ø> (ø)
...ks/python/apache_beam/runners/interactive/utils.py 95.08% <100.00%> (+0.39%) ⬆️
sdks/python/setup.py 0.00% <ø> (ø)
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 88.65% <94.11%> (-1.13%) ⬇️
...e_beam/io/gcp/internal/clients/storage/__init__.py 77.77% <77.77%> (ø)
...apache_beam/runners/dataflow/internal/apiclient.py 77.34% <75.00%> (-0.42%) ⬇️
sdks/python/apache_beam/io/gcp/gcsio_overrides.py 70.00% <70.00%> (ø)
..._beam/runners/portability/sdk_container_builder.py 37.93% <8.33%> (+1.03%) ⬆️
... and 2 more

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm damccorm marked this pull request as ready for review September 28, 2023 16:59
@damccorm
Copy link
Contributor Author

R: @BjornPrime @johnjcasey

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm damccorm merged commit 56b1259 into master Sep 28, 2023
83 of 85 checks passed
@damccorm damccorm deleted the users/damccorm/revert-gcs-client branch September 28, 2023 17:34
BjornPrime added a commit to BjornPrime/my-beam that referenced this pull request Oct 17, 2023
@ghost ghost mentioned this pull request Nov 8, 2023
3 tasks
shunping pushed a commit to shunping/beam that referenced this pull request Nov 16, 2023
The two commits are merged into one:
* Reapply "Replace StorageV1 client with GCS client (apache#28079)" (apache#28721)
* added project parameter to apiclient
johnjcasey pushed a commit that referenced this pull request Nov 16, 2023
* Cherry pick two previous commits on migrating gcs client

The two commits are merged into one:
* Reapply "Replace StorageV1 client with GCS client (#28079)" (#28721)
* added project parameter to apiclient

* Initialze storage client with project from pipeline option.

---------

Co-authored-by: Bjorn Pedersen <bjornpedersen@google.com>
jto pushed a commit to jto/beam that referenced this pull request Nov 17, 2023
* Cherry pick two previous commits on migrating gcs client

The two commits are merged into one:
* Reapply "Replace StorageV1 client with GCS client (apache#28079)" (apache#28721)
* added project parameter to apiclient

* Initialze storage client with project from pipeline option.

---------

Co-authored-by: Bjorn Pedersen <bjornpedersen@google.com>
@jto jto mentioned this pull request Nov 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants