Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better flag documentation. #28753

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Better flag documentation. #28753

merged 2 commits into from
Oct 2, 2023

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 29, 2023

  • improves documentation for a missing pipeline option:

Drive by changes:

  • Remove flag modifications in apply calls: Adding experiments is now also done in run_pipeline . apply() seems like a wrong place to do this.
  • Cleanup now uncecessary method in DF runner.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@tvalentyn tvalentyn closed this Sep 29, 2023
@tvalentyn tvalentyn reopened this Sep 29, 2023
@tvalentyn tvalentyn marked this pull request as draft September 29, 2023 22:48
@tvalentyn
Copy link
Contributor Author

Run Python 3.9 PostCommit

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #28753 (ab4e352) into master (8031162) will decrease coverage by 0.02%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28753      +/-   ##
==========================================
- Coverage   72.25%   72.23%   -0.02%     
==========================================
  Files         684      684              
  Lines      101241   101236       -5     
==========================================
- Hits        73147    73125      -22     
- Misses      26516    26533      +17     
  Partials     1578     1578              
Flag Coverage Δ
python 82.76% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...on/apache_beam/runners/dataflow/dataflow_runner.py 80.90% <ø> (+0.01%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robertwb robertwb changed the title Misc code cleanup. Better flag documentation. Oct 2, 2023
@tvalentyn tvalentyn marked this pull request as ready for review October 2, 2023 23:49
@tvalentyn tvalentyn merged commit bd1c95c into master Oct 2, 2023
77 checks passed
@tvalentyn tvalentyn deleted the tvalentyn-patch-2 branch October 2, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants