Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failing Test]: XVR tests running on VR test suites causing test failure #30353

Closed
1 of 16 tasks
Abacn opened this issue Feb 20, 2024 · 4 comments · Fixed by #30354
Closed
1 of 16 tasks

[Failing Test]: XVR tests running on VR test suites causing test failure #30353

Abacn opened this issue Feb 20, 2024 · 4 comments · Fixed by #30354

Comments

@Abacn
Copy link
Contributor

Abacn commented Feb 20, 2024

What happened?

#29924 merged core-construction-java into java-core. After that many validation runner tests failed:

org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$GroupByKeyTest
FAILED	0.076s	0.076s	0.076s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$SingleInputOutputTest
FAILED	0.071s	0.071s	0.071s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$FlattenTest
FAILED	0.066s	0.066s	0.066s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$PythonDependenciesTest
FAILED	0.066s	0.066s	0.066s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$MultiInputOutputWithSideInputTest
FAILED	0.065s	0.065s	0.065s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$CombineGloballyTest
FAILED	0.061s	0.061s	0.061s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$CoGroupByKeyTest
FAILED	0.056s	0.056s	0.056s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$CombinePerKeyTest
FAILED	0.056s	0.056s	0.056s	
org.apache.beam.sdk.util.construction.ValidateRunnerXlangTest$PartitionTest
FAILED	0.051s	0.051s	0.051s	

These tests are not supposed to run in VR test suites. On the other hand, also checked that XVR test suites no longer run these tests.

We should exclude these tests from running in VR while add them back to XVR

Issue Failure

Failure: Test is continually failing

Issue Priority

Priority: 1 (unhealthy code / failing or flaky postcommit so we cannot be sure the product is healthy)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn
Copy link
Contributor Author

Abacn commented Feb 20, 2024

CC: @kennknowles

@chamikaramj
Copy link
Contributor

XVR test suites no longer run these tests.

Any idea why ? XVR tests are supported to include these tests.

@github-actions github-actions bot added this to the 2.55.0 Release milestone Feb 21, 2024
@kennknowles
Copy link
Member

Do we need to roll back? Is it a configuration problem or a functionality problem?

@Abacn
Copy link
Contributor Author

Abacn commented Feb 21, 2024

It's a configuration problem. XVR test didn't run tests in core (that moved from runners-core-construction) because the change here: https://github.com/apache/beam/pull/29924/files#r1496122168 . VR tests attempted to run those tests because it always has core test jar in its classpath, and the change added those test originally in runner-core-construction to java-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants