Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: TypedSchemaTransformProvider should generate Schema field names with lower_snake_case convention #31061

Closed
1 of 16 tasks
ahmedabu98 opened this issue Apr 19, 2024 · 0 comments · Fixed by #30910
Closed
1 of 16 tasks

Comments

@ahmedabu98
Copy link
Contributor

ahmedabu98 commented Apr 19, 2024

What needs to happen?

TypedSchemaTransformProvider takes advantage of DefaultSchema and AutoValueSchema to convert an AutoValue config object to a Row.
AutoValueSchema is a GetterBasedSchemaProvider which simply infers names from an object's getter methods. The end result is a Row with field names in lowerCamelCase convention.

Since SchemaTransforms are intended for external (ie. non-Java) languages, we want to generate field names that are in lower_snake_case convention. Preferably, this would be done directly in TypedSchemaTransformProvider.

P.S. TypedSchemaTransformProvider's configFromRow() method should also be updated to accept a row with snake_case field names.

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant