Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in _get_function_body_without_inners for module sdks.python.transforms.core #32591

Conversation

DKER2
Copy link
Contributor

@DKER2 DKER2 commented Sep 29, 2024

Fixes #28061
Some functions are defined in a class like this:

class A:
     @Tagging
     def process():

The current function does not remove @tagging because the line begins with a space, rather than directly with the @ symbol. This will lead to miss-warning of class apache_beam.dataframe.convert.DataFrameToRowsFn


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@DKER2 DKER2 changed the title add strip Fix a bug in _get_function_body_without_inners for module sdks.python.transforms.core Sep 29, 2024
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

@DKER2 - which issues is this fixing? I think the description mentions an unrelated issue.

@tvalentyn
Copy link
Contributor

ah, nvm, I understand it now.

@tvalentyn tvalentyn merged commit aadb695 into apache:master Oct 1, 2024
91 of 92 checks passed
@tvalentyn
Copy link
Contributor

Thank you, @DKER2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Issue the warning messages when the process method in DoFn does not return anything
2 participants