Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read write request leak when executor throw RejectedExecutionException #4024

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fix read write request leak when executor throw RejectedExecutionException #4024

merged 1 commit into from
Aug 29, 2023

Conversation

lifepuzzlefun
Copy link
Contributor

No description provided.

horizonzy
horizonzy approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

hangc0276
hangc0276 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@hangc0276 hangc0276 added this to the 4.17.0 milestone Jul 17, 2023
AnonHxy
AnonHxy approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@AnonHxy AnonHxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276
Copy link
Contributor

rerun failure checks

@hangc0276
Copy link
Contributor

@zymap Please help take a look at this PR, thanks.

zymap

This comment was marked as resolved.

Sign in to view

zymap
zymap approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@zymap zymap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 closed this Aug 10, 2023
@hangc0276 hangc0276 reopened this Aug 10, 2023
@zymap zymap merged commit 0b0fe0b into apache:master Aug 29, 2023
16 checks passed
zymap pushed a commit that referenced this pull request Aug 29, 2023
@lifepuzzlefun @zymap
fix read write request leak when executor full. (#4024)
25c5e7f 
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
(cherry picked from commit 0b0fe0b)
zymap pushed a commit that referenced this pull request Dec 7, 2023
@lifepuzzlefun @zymap
fix read write request leak when executor full. (#4024)
314170d 
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
(cherry picked from commit 0b0fe0b)
gaozhangmin pushed a commit to gaozhangmin/bookkeeper that referenced this pull request Feb 20, 2024
Fix read write request leak when executor throw RejectedExecutionExce…
7f14f6e 
…ption apache#4024
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@lifepuzzlefun @lifepuzzlefun1
fix read write request leak when executor full. (apache#4024)
345c027 
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@AnonHxy AnonHxy AnonHxy approved these changes

@horizonzy horizonzy horizonzy approved these changes

@zymap zymap zymap approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@wenbingshen wenbingshen Awaiting requested review from wenbingshen

@StevenLuMT StevenLuMT Awaiting requested review from StevenLuMT

Assignees

@lifepuzzlefun lifepuzzlefun

Labels
cherry-picked/branch-4.15 cherry-picked/branch-4.16 release/4.14.9 release/4.15.5 release/4.16.3
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lifepuzzlefun @hangc0276 @AnonHxy @horizonzy @zymap @lifepuzzlefun1