Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bookie shell getUsage msg #4046

Closed
wants to merge 2 commits into from
Closed

Fix bookie shell getUsage msg #4046

wants to merge 2 commits into from

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Aug 11, 2023

Descriptions of the changes in this PR:

Motivation

Fix bookie shell getUsage message.

When we execute the bookkeeper shell bin/bookkeeper shell, it will print the help messages:
image

However the long options should be --, instead of-;

Changes

Change - to -- in the getUsage() method.

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 11, 2023

rerun failure checks

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 11, 2023

rerun failure checks

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 29, 2023

@hangc0276 @zymap @eolivelli @dlg99 PTAL

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 29, 2023

Oh.. The long cmd with - could also work. So it looks that there is no need to change the usage messages. I will close this patch. Thanks all

@AnonHxy AnonHxy closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AnonHxy