Disable annoying logs when segments is empty #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not familiar with this part. Please correct me If I do something wrong. :) |
hangc0276
reviewed
Aug 14, 2023
| @@ -1014,6 +1014,9 @@ public void onSegmentsUpdated(List<LogSegmentMetadata> segments) { | |||
| if (!started.get()) { | |||
| return; | |||
| } | |||
| if (segments == null || segments.isEmpty()) { | |||
| return; | |||
| } | |||
| logger.info("segments is updated with {}", segments); | |||
| processLogSegments(segments); | |||
There was a problem hiding this comment.
If we returned when the segments is empty, it will skip call processLogSegments(segments);, and I'm not sure what's the impact
There was a problem hiding this comment.
processLogSegments seems to do nothing in case of empty segments List
dlg99
approved these changes
May 30, 2024
dao-jun
approved these changes
May 30, 2024
|
re-triggering CI by close/open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I saw some logs print repeatedly.
Changes
Return directly when segments are empty.