Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be revision-friendly and do not use revisions by default on Knative profile #289

Closed
nicolaferraro opened this issue Dec 13, 2018 · 3 comments
Assignees
Labels
area/knative Related to Knative
Milestone

Comments

@nicolaferraro
Copy link
Member

Service revisions are a nice thing as they allow to route traffic to different versions of the integration at the same time if needed.

But each time you do a redeploy a new revision (pod, running) is added and it scales down only after 5 minutes.
What's even worse is that if the deployment fails it's retried multiple times, generating at every cycle a new revision, blocking the whole cluster.

We should understand why a redeployment results in two different revisions if nothing changes.
We should use a different strategy by default, to avoid creating multiple pods if not required.

@nicolaferraro nicolaferraro self-assigned this Dec 13, 2018
@astefanutti astefanutti added the area/knative Related to Knative label Sep 25, 2019
@nicolaferraro
Copy link
Member Author

No longer a problem.

@nicolaferraro
Copy link
Member Author

I'm not sure about the digest.. Let me verify..

@nicolaferraro nicolaferraro reopened this Mar 18, 2020
@nicolaferraro nicolaferraro added this to the 1.0.0 milestone Mar 18, 2020
@nicolaferraro
Copy link
Member Author

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/knative Related to Knative
Projects
None yet
Development

No branches or pull requests

2 participants