-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cordova-fetch is much slower at prepare #52
Comments
This is a known issue. The good news is that it will be fixed in Cordova 9, the bad news is that Cordova 9 isn't ready to be released yet. |
Dumb question. Is there any sort of time frame for Cordova 9 at this point? |
I don't want to make any sort of official sounding statement that could be interpreted as committing to a date 😅 |
I won't hold you to the fire 😀. We all cringe when asked for a "release date". |
@dpogue, is there any updates on this issue? |
In my app more than 30 minutes to donwload all the plugins, this is a big trouble |
@videmort totally agree, do some builds in a CI environment is so painful 🔥 |
@videmort you so true, i can take a nap while reinstalling the cordova plugins |
@manudefrutosvila you can take 2-3 nap per day. |
Yes, we are aware. This affects all of my CI builds too. The issue has been fixed and released as cordova-fetch 2.0.0. We're in the process of doing a major version release for all the platforms and tooling which will pull in this updated version. |
@dpogue, is there an ETA when the new version will be released? |
Hi, Seems like new major Cordova-Android and Cordova-iOS were released (https://cordova.apache.org/announcements/2019/02/16/cordova-android-release-8.0.0.html, Is the problem resolved ? |
afaik those are only the platforms fetched by cordova-fetch. |
@janpio any eta when cli 9 will be released? |
As soon as it's ready. The Android and iOS releases where some of the last "big" releases, so we are definitely talking more weeks than months. |
Any news? |
Very close now: |
This has been released as part of Cordova 9. Please try installing |
The prepare is wicked fast with |
Prepare is no faster for me on 9.0.0 than on 8.x. Is there something additional I need to do to see the increased speed? |
That is odd. Just updating to |
I did not install globally, but, I did execute I wouldn't expect 10-15 seconds as I am doing a full restore prepare (incl. fetch) -- I started with no |
Yeah, when switching over to |
If you did not run Plugins being installed from git URLs need to be fetched every time, because npm doesn't give us a good way to verify that it's the correct commit. |
It's really fast now, thx! |
It would appear that when I run a
cordova prepare
using cordova-fetch, it takes drastically longer than when I run it without cordova-fetch.I have tested this on a repo with no platforms or plugins present in the directory structure, and about 20 plugins and 2 platforms defined in the package.json.
Using cordova 6.5,
cordova prepare
runs in about 30 seconds to add the platforms and plugins.Using cordova 7,
cordova prepare --nofetch
takes about the same amount of time.Using cordova 7,
cordova prepare
takes about somewhere around 5 minutes.Using cordova 8,
cordova prepare
takes about the same amount of time as cordova 7 with the fetch.Is this a known issue? This is a pretty painful amount of time to have to wait for a clean build. It causes builds on our build server to bloat quite significantly.
Any help would be appreciated.
Thanks!
The text was updated successfully, but these errors were encountered: