-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links with target _blank are not working on iOS inside inAppBrowser when wkwebview is enabled #390
Comments
I am also seeing this exact same thing on 3.1.0-dev. I tracked it down to the I did modify the code locally to always make the request in |
I am extremely new to Objective-C, Swift, Cordova, etc., so keep that in mind. It appears as if the lock acquired by previous calls to |
I figured this out on my side. I am posting here so it might help anyone who runs in to the same issue. Cordova's CDVWKWebViewEngine checks to see if the view controller you are instantiating implements UINavigationDelegate. If it does, it uses that instead of the default implementation in CDVWKWebViewEngine. Since I had implemented my own navigation delegate, the default's implementation of didFinishNavigation wasn't being called and that method is what releases the lock. Unfortunately, you have to know this if you want to implement the delegate yourself. So, for now, maybe not the best solution, but I am just doing
|
Hello, This happened to me also, inappbrowser with usewkwebview =yes , will not open any links with <a href= target=_blank> (this mean for browser : to open the link in new tab) but for inappbroswer, it should open in the same window.) I hope from the team to solve this issue. |
This issue still seems to be pending. I have similar issues. Even with a brand new ionic v1 app which comes with default wkwebview plugin and after I added the latest cordova inappbrowser plugin, the in app browser doesn't open. After I removed wkwebview plugin, the in app browser is working. I am stuck with this issue for the past week and cannot make this work and can't find any solutions as I did a lot of searching this past week. This is the closest thread where the same issue is discussed. Can someone please help ? |
Same here, |
Has this been fixed yet? :'( |
I'm having this same issue. |
Please use the latest version of this plugin or the master version. As the documentation for this plugin: target: The target in which to load the URL, an optional parameter that defaults to _self. (String) _self: Opens in the Cordova WebView if the URL is in the white list, otherwise it opens in the InAppBrowser. So,
Example:
Example: |
Additional inofrmation: (NOTE: wkwebview has been integrated to the plugin it self, there is no need to use 'wkwebview=yes' any more.) So if you used : Regards |
I couldn't get inAppBrowser with |
Links with target _blank are not working on iOS when they are opened from the inAppBrowser and wkwebview is enabled. This is also an issue with a form element which has target _blank. Nothing happens when you tap link or submit form. Links without _blank are working correctly.
Tested with the master version 3.1.0-dev and setting
usewkwebview=yes
Happens on various iPhones and simulator.
Here is the repo for minimal reproduction of the issue:
https://github.com/teroauralinna/cordova-iab-wkwebview
In the issue demo, click Open inAppBrowser and then Link with _blank doesn't work! => nothing happens
The text was updated successfully, but these errors were encountered: