Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join support #12

Open
7 of 10 tasks
viirya opened this issue Feb 12, 2024 · 4 comments
Open
7 of 10 tasks

Join support #12

viirya opened this issue Feb 12, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented Feb 12, 2024

This is an umbrella ticket for adding Join support to Comet. In Spark, there are basically three types of Join operators: BroadcastJoin, HashJoin, SortMergeJoin. In DataFusion, two Join operators are supported: HashJoin, SortMergeJoin (experimental).

We are going to delegate Spark Join operators to correspond DataFusion Join operators. We will also go to improve DataFusion Join operators if needed.

SortMergeJoin

HashJoin

BroadcastJoin

Other Join operators (Cross Join)

@viirya viirya self-assigned this Feb 12, 2024
@viirya viirya added the enhancement New feature or request label Feb 14, 2024
@mwiewior
Copy link

Hey @viirya - it's really awesome ! Do you happen to know when approx these BHJ and shuffle components will be open sourced?

@viirya
Copy link
Member Author

viirya commented Feb 15, 2024

Hi @mwiewior

I will open source shuffle components soon. For join support, it is in development now. We already have working code but get some test failure on Spark tests. Once these test failures are resolved, we will open source it.

@viirya
Copy link
Member Author

viirya commented Feb 15, 2024

For shuffle, we just remove it from the initial open source code. So the code is ready, we only need to add it back to Comet.

@mwiewior
Copy link

Great news ! Thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants