Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maturin version to satisfy conda-forge constraints? #701

Closed
Tracked by #879
charlesbluca opened this issue May 15, 2024 · 4 comments
Closed
Tracked by #879

Bump maturin version to satisfy conda-forge constraints? #701

charlesbluca opened this issue May 15, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@charlesbluca
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Availability of this package on conda-forge for each Python minor version is dependent on there being an associated maturin package built against that minor version - in the case of python 3.12, there are no builds of maturin that satisfy >=0.15,<0.16, blocking the ability to publish packages for 3.12 (conda-forge/datafusion-feedstock#44 (comment)).

Describe the solution you'd like
Bumping the maturin version constraints to something that contains at least 1.2.3 would give us access to 3.12 builds, allowing conda-forge packages of this project to be published for python 3.12.

Additional context
Discussion around this is surrounding conda-forge/datafusion-feedstock#44.

@charlesbluca charlesbluca added the enhancement New feature or request label May 15, 2024
@Michael-J-Ward
Copy link
Contributor

#725 is merged and upgrades maturin on main.

Does conda-forge pull from main? Or do we need a new release to test if that fix solves the issue?

@charlesbluca
Copy link
Contributor Author

charlesbluca commented Jun 12, 2024

Does conda-forge pull from main? Or do we need a new release to test if that fix solves the issue?

conda-forge pulls the sdist for a versioned release from PyPI, but I don't actually think the maturin constraint contained in this code forces us to that maturin version; for example, in conda-forge/datafusion-feedstock#44, we are rebuilding using the 34.0.0 source code, which constrains maturin>=0.15,<0.16, we are still able to pull a newer maturin version and build successfully with it.

In short, I think we should be safe to move to the updated constraint in #725 to unblock some of the older conda-forge that have been blocked:

And then continue using this updated constraint for future conda-forge builds moving forward.

As a side note, would you be interested in being added as a maintainer of the linked feedstock? This would give you write access to the repo as well as notifications of these past build attempts.

@Michael-J-Ward
Copy link
Contributor

I don't have a good mental model for conda and its ecosystem, but I just started watching the feedstock repo so maybe I'll learn a little.

@Michael-J-Ward
Copy link
Contributor

Resolved by #725.

The final arch migrator appears to be something different. conda-forge/datafusion-feedstock#46 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants