Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support from first in select #1429

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support from first in select #1429

wants to merge 1 commit into from
+145 −72

Conversation

samuelcolvin
Copy link
Contributor

fix #1400

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10862007115

Details

  • 55 of 92 (59.78%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.23%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/duckdb.rs 0 2 0.0%
src/dialect/generic.rs 0 2 0.0%
src/dialect/mod.rs 0 2 0.0%
src/ast/query.rs 0 4 0.0%
src/parser/mod.rs 55 82 67.07%
Totals Coverage Status
Change from base Build 10817360923: -0.1%
Covered Lines: 29430
Relevant Lines: 32982
💛 - Coveralls

@samuelcolvin
Copy link
Contributor Author

Let's get #1430 fixed first.

@github-actions GitHub Actions
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FROM first in SELECT statements
2 participants
@samuelcolvin @coveralls