Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for when partial aggregation mode is hit #11815

Closed
alamb opened this issue Aug 5, 2024 · 1 comment · Fixed by #11706
Closed

Metrics for when partial aggregation mode is hit #11815

alamb opened this issue Aug 5, 2024 · 1 comment · Fixed by #11706
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Aug 5, 2024

Is your feature request related to a problem or challenge?

@korowa added "skip partial aggregation mode" in #11627 which helps with high cardinality aggregates by doing minimal work for the first phase of the aggregation. This mode is triggered dynamically based on how effective the first aggregation phase is working.

However, it is not clear from the metrics (e.g. the output of EXPLAIN ANALYZE plans) when this mode

Describe the solution you'd like

I would like some sort of metric that can be used to determine when the partial aggregation phase has been invoked

Describe alternatives you've considered

I think the number of convert_to_state rows is a good metric -- 0 means no partial aggregation was done, and more than 1 gives the number of rows that were subject to the partial aggregate.

Additional context

No response

@alamb alamb added the enhancement New feature or request label Aug 5, 2024
@alamb alamb self-assigned this Aug 5, 2024
@alamb
Copy link
Contributor Author

alamb commented Aug 5, 2024

I have a draft PR for this here; #11706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant