Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert_or_update and get_payloads to map #12701

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dmitrybugakov
Copy link
Contributor

Which issue does this PR close?

Closes #12594

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Oct 1, 2024
@comphead
Copy link
Contributor

comphead commented Oct 1, 2024

Thanks @dmitrybugakov please help understand what are use cases for this functions in DF or downstream projects?

@dmitrybugakov
Copy link
Contributor Author

@comphead Thanks for the review!
I'm using this functions as part of the mode function implementation, specifically for String/View types.

@comphead
Copy link
Contributor

comphead commented Oct 1, 2024

Right but still not sure should it be part of DataFusion core. The mode function is in contrib package, however DF core is heavily using StringViews.
@alamb @jayzhan211 WDYT on the core extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add insert_or_update and get_payloads methods to binary_map/binary_view_map
2 participants