Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap_hash_join is no longer public so comet doesn't compile #13898

Closed
alamb opened this issue Dec 24, 2024 · 0 comments · Fixed by #13899
Closed

swap_hash_join is no longer public so comet doesn't compile #13898

alamb opened this issue Dec 24, 2024 · 0 comments · Fixed by #13899
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Dec 24, 2024

Describe the bug

When upgrading comet to use the latest datafusion pun (andygrove/datafusion-comet#1) it fails to compile with the following error:

error[E0603]: function `swap_hash_join` is private
   --> core/src/execution/planner.rs:56:41
    |
56  |     physical_optimizer::join_selection::swap_hash_join,
    |                                         ^^^^^^^^^^^^^^ private function
    |
note: the function `swap_hash_join` is defined here
   --> /Users/andrewlamb/.cargo/git/checkouts/datafusion-c36d6291a88e48f3/e99e02b/datafusion/core/src/physical_optimizer/join_selection.rs:179:1
    |
179 | / pub(crate) fn swap_hash_join(
180 | |     hash_join: &HashJoinExec,
181 | |     partition_mode: PartitionMode,
182 | | ) -> Result<Arc<dyn ExecutionPlan>> {
    | |___________________________________^

This appears to have been introduced in #13893 from @berkaysynnada

To Reproduce

See andygrove/datafusion-comet#1

Expected behavior

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant