-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming Tests Discussion #1505
Comments
@alamb @xudong963 @liukun4515 Any opinion on this or would you prefer I just run with a PR on my own ideas? |
Makes sense to me
That would also be a great idea Sorry for the lack of feedback earlier - I can't keep up with all the tickets 🤯 somedays :) |
@hntd187 agree with you. I can start this task. If you finish it, I would like to review it. |
Make sense to me, looking forward to your ticket! I can help review it. @hntd187 |
@hntd187 |
I think this is completed in #1491 |
FYI I plan to move some tests out of context.rs into the sql_integration test -- I'll try and get that done prior to the big rename 🏃 |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I am starting the discussion on how we want to rename some of the tests post the refactoring of the tests in #1491
Describe the solution you'd like
Some of the tests have names that don't necessarily have anything to do with what they are testing. Most universally the tests that begin with
csv_*
come to mind. Does that prefix have any value? I think we should just universally remove them. Maybe another suggestion maybe to instead prefix tests with what functionality they are meant to actually test?Describe alternatives you've considered
Not renaming them?
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: