You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the divide method, we may lose of precision by converting the i128 to f64.
We use the f64 to store the larger range of data, but we lose the precision.
I will try to figure out this issue and resolve this.
I think the code using f64 for decimal division is out-of-dated for a while. We are using i128 directly to process it. That being said I don't expect this is still an issue.
But now I find a bug in the arithmetic operation. https://github.com/apache/arrow-datafusion/blob/c91efc27658e58264c4f346a5cfdec8810179e90/datafusion/physical-expr/src/expressions/binary.rs#L302 and https://github.com/apache/arrow-datafusion/blob/c91efc27658e58264c4f346a5cfdec8810179e90/datafusion/physical-expr/src/expressions/binary.rs#L307
In the divide method, we may lose of precision by converting the
i128
tof64
.We use the
f64
to store the larger range of data, but we lose the precision.I will try to figure out this issue and resolve this.
Originally posted by @liukun4515 in #2233 (comment)
The text was updated successfully, but these errors were encountered: