Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concat from Dataframe API no longer accepts multiple expressions #226

Closed
jorgecarleitao opened this issue Apr 30, 2021 · 1 comment · Fixed by #761 or #768
Closed

Concat from Dataframe API no longer accepts multiple expressions #226

jorgecarleitao opened this issue Apr 30, 2021 · 1 comment · Fixed by #761 or #768
Labels
bug Something isn't working datafusion Changes in the datafusion crate

Comments

@jorgecarleitao
Copy link
Member

The function has signature concat(Expr), while some time ago it had the signature concat(&[Expr]).

I think that it makes sense to be concat(&[Expr]), as we AFAIK we hope to concatenate more than one expression.

Found while trying to bump python-datafusion to latest DataFusion.
@jorgecarleitao jorgecarleitao added bug Something isn't working datafusion Changes in the datafusion crate labels Apr 30, 2021
@jorgecarleitao jorgecarleitao mentioned this issue Apr 30, 2021
Merged
@jorgecarleitao jorgecarleitao mentioned this issue Jun 2, 2021
Closed
@jimexist
Copy link
Member

i can probably take a look this week

@jimexist jimexist mentioned this issue Jul 21, 2021
Merged
@jimexist jimexist mentioned this issue Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working datafusion Changes in the datafusion crate
Projects
None yet
Milestone
No milestone
2 participants
@jimexist @jorgecarleitao