Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove core/logical_plan module #2683

Closed
andygrove opened this issue Jun 2, 2022 · 1 comment · Fixed by #3816
Closed

Remove core/logical_plan module #2683

andygrove opened this issue Jun 2, 2022 · 1 comment · Fixed by #3816
Assignees
@andygrove
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

andygrove commented Jun 2, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There has been a lot of refactoring recently in order to implement subquery support and also to move the SQL query planner and the logical optimization rules into their own crates.

As a result, we now have many re-exports in the core/logical_plan module that were implemented to reduce the size of PRs. I would like to propose removing these re-exports as part of stabilizing the public API for DataFusion.

Describe the solution you'd like
Remove many re-exports and update imports to use the real locations.

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added the enhancement New feature or request label Jun 2, 2022
This was referenced Jun 2, 2022
Closed
Closed
@andygrove
Copy link
Member Author

I now plan on working on this after the 9.0.0 release

@andygrove andygrove changed the title Remove some of the re-exports within the core crate Remove core/logical_plan module Jun 5, 2022
This was referenced Jun 5, 2022
Merged
Merged
@andygrove andygrove mentioned this issue Jun 14, 2022
Closed
@andygrove andygrove mentioned this issue Aug 26, 2022
Merged
@andygrove andygrove self-assigned this Sep 2, 2022
@andygrove andygrove mentioned this issue Sep 2, 2022
Merged
@alamb alamb added good first issue Good for newcomers and removed good first issue Good for newcomers labels Sep 3, 2022
@andygrove andygrove mentioned this issue Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finish removing deprecated datafusion::logical_plan module andygrove/datafusion
2 participants
@alamb @andygrove