Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Optimize onto DataFrame #4626

Closed
tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4750
Closed

Move Optimize onto DataFrame #4626

tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4750
Assignees
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The logic to optimize a LogicalPlan currently lives on SessionContext. This creates a couple of problems:

  • Forces query_execution_start_time to be stored on SessionState when it is a per-query property
  • DataFrame ends up calling back to SessionContext in order to optimize its plans, creating circular coupling between them

Describe the solution you'd like

I originally thought we might need to introduce a new per-query container, but it turns out DataFrame already fits this role nicely, especially following the changes in #4624.

Describe alternatives you've considered

Additional context

#4621 #4622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant