Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change all quotes to smart quotes within error messages #583

Closed
jimexist opened this issue Jun 18, 2021 · 3 comments · Fixed by #581
Closed

change all quotes to smart quotes within error messages #583

jimexist opened this issue Jun 18, 2021 · 3 comments · Fixed by #581
Labels
enhancement New feature or request

Comments

@jimexist
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

so far some of the test messages require escaping either single ' or double " quotes. this is error prone and and sometimes introduces confusions.

Describe the solution you'd like

we can easily resolve this issue by replacing all current and future usage of quotes into smart quotes and

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jimexist jimexist added the enhancement New feature or request label Jun 18, 2021
@jimexist
Copy link
Member Author

@Dandandan @alamb @houqp and @jorgecarleitao WDYT?

@Dandandan
Copy link
Contributor

I am not sure changing the error messages for the sake of easier testing makes sense to me.

What about using raw string literals in the tests instead?https://rahul-thakoor.github.io/rust-raw-string-literals/

This was referenced Jun 18, 2021
@jimexist
Copy link
Member Author

I am not sure changing the error messages for the sake of easier testing makes sense to me.

What about using raw string literals in the tests instead?https://rahul-thakoor.github.io/rust-raw-string-literals/

it's a great point - i'll close this in #581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants