Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounded_order_preserving_variants configuration setting is confusingly named #7722

Closed
alamb opened this issue Oct 2, 2023 · 0 comments · Fixed by #7723
Closed

bounded_order_preserving_variants configuration setting is confusingly named #7722

alamb opened this issue Oct 2, 2023 · 0 comments · Fixed by #7723
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Oct 2, 2023

Is your feature request related to a problem or challenge?

While debugging an issue upgrading our code to use DataFuson, @ozankabak pointed me at the following config: #7671 (comment)

This setting (I think) controls if the DataFusion planner should prefer using the existing sort order or trying to maximize paralleilsm using repartition and re-sorting

It turns out to be the right one, but I don't think I would have found it without @ozankabak 's suggestion

Describe the solution you'd like

I would like to more easily understand what the setting does from an end-user perspective -- with some better docs and a different name (prefer_existing_sort)

Describe alternatives you've considered

We could also just update the docs and leave the name alone

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant