Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failure / Panic when to_timestamp() called #7939

Closed
comphead opened this issue Oct 26, 2023 · 3 comments · Fixed by #7941
Closed

CI Failure / Panic when to_timestamp() called #7939

comphead opened this issue Oct 26, 2023 · 3 comments · Fixed by #7941
Assignees
Labels
bug Something isn't working

Comments

@comphead
Copy link
Contributor

Describe the bug

After merging #7844 AND some other PRs I can see the tests and to_timestamp() calls are panicking

External error: query failed: DataFusion error: Arrow error: Invalid argument error: column types must match schema types, expected Timestamp(Nanosecond, None) but found Timestamp(Second, None) at column index 0

Solely #7844 passed all the tests

To Reproduce

select to_timestamp(cast (1 as int));

Expected behavior

No panic

Additional context

No response

@comphead comphead added the bug Something isn't working label Oct 26, 2023
@alamb
Copy link
Contributor

alamb commented Oct 26, 2023

This is failing on CI as well

https://github.com/apache/arrow-datafusion/actions/runs/6655614609/job/18086447772

External error: query failed: DataFusion error: Arrow error: Invalid argument error: column types must match schema types, expected Timestamp(Nanosecond, None) but found Timestamp(Second, None) at column index 0
[SQL] select to_timestamp(cast (1 as int));
at test_files/timestamps.slt:405

Error: Execution("1 failures\n\nbacktrace:    0: datafusion_common::error::DataFusionError::get_back_trace\n             at /__w/arrow-datafusion/arrow-datafusion/datafusion/common/src/error.rs:436:30\n   1: sqllogictests::run_tests::{{closure}}\n             at ./bin/sqllogictests.rs:124:9\n   2: sqllogictests::main::{{closure}}\n             at ./bin/sqllogictests.rs:55:17\n   3: tokio::runtime::park::CachedParkThread::block_on::{{closure}}\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/park.rs:282:63\n   4: tokio::runtime::coop::with_budget\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/coop.rs:107:5\n   5: tokio::runtime::coop::budget\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/coop.rs:73:5\n   6: tokio::runtime::park::CachedParkThread::block_on\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/park.rs:282:31\n   7: tokio::runtime::context::blocking::BlockingRegionGuard::block_on\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/context/blocking.rs:66:9\n   8: tokio::runtime::scheduler::multi_thread::MultiThread::block_on::{{closure}}\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/scheduler/multi_thread/mod.rs:87:13\n   9: tokio::runtime::context::runtime::enter_runtime\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/context/runtime.rs:65:16\n  10: tokio::runtime::scheduler::multi_thread::MultiThread::block_on\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/scheduler/multi_thread/mod.rs:86:9\n  11: tokio::runtime::runtime::Runtime::block_on\n             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.33.0/src/runtime/runtime.rs:350:45\n  12: sqllogictests::main\n             at ./bin/sqllogictests.rs:55:5\n  13: core::ops::function::FnOnce::call_once\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/ops/function.rs:250:5\n  14: std::sys_common::backtrace::__rust_begin_short_backtrace\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/sys_common/backtrace.rs:154:18\n  15: std::rt::lang_start::{{closure}}\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/rt.rs:166:18\n  16: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/ops/function.rs:284:13\n  17: std::panicking::try::do_call\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/panicking.rs:502:40\n  18: std::panicking::try\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/panicking.rs:466:19\n  19: std::panic::catch_unwind\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/panic.rs:142:14\n  20: std::rt::lang_start_internal::{{closure}}\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/rt.rs:148:48\n  21: std::panicking::try::do_call\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/panicking.rs:502:40\n  22: std::panicking::try\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/panicking.rs:466:19\n  23: std::panic::catch_unwind\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/panic.rs:142:14\n  24: std::rt::lang_start_internal\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/rt.rs:148:20\n  25: std::rt::lang_start\n             at /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/std/src/rt.rs:165:17\n  26: main\n  27: <unknown>\n  28: __libc_start_main\n  29: _start\n")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`

@alamb
Copy link
Contributor

alamb commented Oct 26, 2023

@comphead is this something you plan to fix? Since it is blocking a clean CI run for all PRs I think it is high priority and I will fix it later today if someone else hasn't beat me to it

@alamb alamb changed the title Panic when to_timestamp() called CI Failure / Panic when to_timestamp() called Oct 26, 2023
@comphead
Copy link
Contributor Author

@alamb I'll try to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants