Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RawTable API in hash join code #826

Closed
Dandandan opened this issue Aug 5, 2021 · 0 comments · Fixed by #827
Closed

Use RawTable API in hash join code #826

Dandandan opened this issue Aug 5, 2021 · 0 comments · Fixed by #827
Labels
enhancement New feature or request performance Make DataFusion faster

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
See the comment here.
#790 (comment)

It looks to me like both the performance and complexity of the hash join code can be improved when using the raw table API instead of.

Describe the solution you'd like
Rewrite the code to use the RawTable api. This should simplify the code and open up some opportunities to improve performance (faster collision checks(?)).

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=9157e7ae2ad4d84f8bd6c358c42722cb

Describe alternatives you've considered
Custom hashmap implementation. It seems to me that using the hashbrown API might result in less code and might be more performant in some cases.

Additional context

@Dandandan Dandandan added enhancement New feature or request performance Make DataFusion faster labels Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Make DataFusion faster
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant