Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move make_array to datafusion-functions #9288

Closed
alamb opened this issue Feb 20, 2024 · 3 comments
Closed

Move make_array to datafusion-functions #9288

alamb opened this issue Feb 20, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Feb 20, 2024

Is your feature request related to a problem or challenge?

Part of #9285 and #8045

The goal is to extract function definitions out of the datafusion core.

Note the make_array function is somewhat special in that it has several special cases in datafusion core at the moment.
Not only do the special cases make it hard to move, it also means some datafusion functionality is not available to scalar udf functions

I think this ticket will be blocked on removing the special case handling of MakeArrayin the expression rewriter(link) -- I will file a follow on ticket

Describe the solution you'd like

Move the make_array function to datafusion-functions-array

Describe alternatives you've considered

No response

Additional context

Note I have a draft PR with some of this code: #9222 but likely won't have time to work on it for a while

@alamb
Copy link
Contributor Author

alamb commented Feb 20, 2024

I think #9289 may be able to help us with the simplify example

@alamb
Copy link
Contributor Author

alamb commented Feb 20, 2024

@jayzhan211 I wonder if you have thoughts or time to work on this ticket?

@jayzhan211
Copy link
Contributor

not sure how to do yet, but I will take it.

/take

@jayzhan211 jayzhan211 self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants