We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #8045
Today there is a nice error message with a hint if a user issues an unknown function
For example, tryng cos2 will have datafusion suggest cos
cos2
cos
DataFusion CLI v36.0.0 ❯ select cos2(1); Error during planning: Invalid function 'cos2'. Did you mean 'cos'?
However, UDFs are never suggested
For example, the function abs has been moved to a ScalarUDF, so now the error message does not suggest this.
abs
DataFusion CLI v36.0.0 ❯ select abs2(1); Error during planning: Invalid function 'abs2'. Did you mean 'acos'?
but in earlier versions of DataFusion where abs was a built in function, it is correctly suggested:
DataFusion CLI v32.0.0 ❯ select abs2(1); Error during planning: Invalid function 'abs2'. Did you mean 'abs'?
I would like UDFs to be included in the suggestsed the error message
Here is where the suggestion is created: https://github.com/apache/arrow-datafusion/blob/cf69d38e80448ec7402f622d2adcfc6edf0b387e/datafusion/sql/src/expr/function.rs#L214-L215
I think it will be a fairly straightforward exercise to extend the list in https://github.com/apache/arrow-datafusion/blob/cf69d38e80448ec7402f622d2adcfc6edf0b387e/datafusion/expr/src/function.rs#L80-L94 to
This came up in the context of #9388, #9388 (comment)
The text was updated successfully, but these errors were encountered:
BuiltInScalarFunction
Nice feature, I would like to try this as I have never touched the sql crate😁
take
Sorry, something went wrong.
arrow_typeof
SteveLauC
Successfully merging a pull request may close this issue.
Is your feature request related to a problem or challenge?
Part of #8045
Today there is a nice error message with a hint if a user issues an unknown function
For example, tryng
cos2
will have datafusion suggestcos
However, UDFs are never suggested
For example, the function
abs
has been moved to a ScalarUDF, so now the error message does not suggest this.but in earlier versions of DataFusion where
abs
was a built in function, it is correctly suggested:Describe the solution you'd like
I would like UDFs to be included in the suggestsed the error message
Describe alternatives you've considered
Here is where the suggestion is created: https://github.com/apache/arrow-datafusion/blob/cf69d38e80448ec7402f622d2adcfc6edf0b387e/datafusion/sql/src/expr/function.rs#L214-L215
I think it will be a fairly straightforward exercise to extend the list in https://github.com/apache/arrow-datafusion/blob/cf69d38e80448ec7402f622d2adcfc6edf0b387e/datafusion/expr/src/function.rs#L80-L94 to
Additional context
This came up in the context of #9388, #9388 (comment)
The text was updated successfully, but these errors were encountered: