Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release verification instructions #9848

Open
andygrove opened this issue Mar 29, 2024 · 2 comments
Open

Improve release verification instructions #9848

andygrove opened this issue Mar 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

andygrove commented Mar 29, 2024

Is your feature request related to a problem or challenge?

The release verification instructions do not specify that we need to increase the Rust stack size. For example, I had to set RUST_MIN_STACK=3000000 for the tests to pass with 37.0.0-rc1.

We also need to set ulimit -n to make sure enough file handles are available.

It may also be useful to be able to control the number of threads used in cargo test when running the verification script.

Describe the solution you'd like

Improve the documentation

Describe alternatives you've considered

No response

Additional context

No response

@andygrove andygrove added the enhancement New feature or request label Mar 29, 2024
@andygrove andygrove self-assigned this Mar 29, 2024
@alamb
Copy link
Contributor

alamb commented Mar 29, 2024

I also hope that work related to #9637 will improve this symptom / reduce the need for the large stacks in debug builds

@waynexia
Copy link
Member

I observed the peak memory usage increases with RUST_MIN_STACK=3000000. It looks more expensive than 3MB...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants