-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-80] Rename field operator
to modify_user_id
#16772
Comments
If this is to be optimized, all relevant frontend and backend codes and table field names need to be modified uniformly. You should create an DSIP first. |
Modified |
Not all |
operator
to modify_user_id
ok |
I don't disagree with this issue, but this kind of change will bring some incompatible changes. Before making any of these kinds of changes to db schema and API schema, need to make a specification firstly, and list all the fields that need to be changes, otherwise this looks very much like a random personal alteration. In the future, if someone think some fields is not suitable, he might submit another pr to change again, will bring an incompatible changes again. |
#16515 In fact, the ideas are similar. Whether to make changes can be discussed, 和 the operation can be postponed if there is not enough support. What do you think? |
This isn't similar to #16515, #16515 has been discussed long time ago, it is not a simple rename operation or code style change, It's a conversion of concepts between workflow and process. |
Search before asking
Motivation
The field named "operator" in the project should be modified to "modify_user_id" for better clarity and easier maintenance
Design Detail
Incompatible changes
operator
tomodifyUserId
.operator
tomodify_user_id
.These incompatible changes may affect users of secondary development based on API and Database.
Compatibility, Deprecation, and Migration Plan
No response
Test Plan
Test by UT.
Code of Conduct
The text was updated successfully, but these errors were encountered: