Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](check) open shorten-64-to-32 error #41197

Merged
merged 1 commit into from
Sep 29, 2024
Merged

[chore](check) open shorten-64-to-32 error #41197

merged 1 commit into from
Sep 29, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Sep 24, 2024

Proposed changes

doris/be/src/pipeline/pipeline_fragment_context.cpp:1160:76: error: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
 1159 |         _sink.reset(new MultiCastDataStreamSinkOperatorX(
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1160 |                 sink_id, sources, thrift_sink.multi_cast_stream_sink.sinks.size(), pool,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Sep 24, 2024

run buildall

@Mryange
Copy link
Contributor Author

Mryange commented Sep 24, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42029 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a2386e155834c696c911ab7082f5e9c3fe52d4e, data reload: false

------ Round 1 ----------------------------------
q1	18243	7562	7369	7369
q2	2523	183	182	182
q3	12000	1219	1272	1219
q4	10917	775	788	775
q5	8186	3185	3148	3148
q6	238	152	148	148
q7	1021	625	611	611
q8	9426	2088	2069	2069
q9	6915	6408	6413	6408
q10	7012	2261	2309	2261
q11	424	249	252	249
q12	412	223	219	219
q13	17788	2990	2967	2967
q14	241	216	212	212
q15	574	543	518	518
q16	662	613	601	601
q17	983	802	789	789
q18	7475	6751	6760	6751
q19	1404	1029	998	998
q20	599	301	288	288
q21	4024	3270	3337	3270
q22	1081	977	981	977
Total cold run time: 112148 ms
Total hot run time: 42029 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7272	7267	7315	7267
q2	334	235	228	228
q3	2942	2822	2798	2798
q4	2008	1720	1676	1676
q5	5363	5414	5417	5414
q6	229	142	139	139
q7	2109	1719	1763	1719
q8	3194	3351	3350	3350
q9	8476	8457	8474	8457
q10	3392	3376	3366	3366
q11	569	478	468	468
q12	761	596	597	596
q13	7250	2999	2982	2982
q14	283	258	264	258
q15	557	514	511	511
q16	725	663	659	659
q17	1767	1573	1534	1534
q18	7762	7393	7427	7393
q19	1688	1472	1541	1472
q20	2025	1803	1789	1789
q21	5409	5270	5219	5219
q22	1131	1017	978	978
Total cold run time: 65246 ms
Total hot run time: 58273 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.27% (9607/25776)
Line Coverage: 28.69% (79538/277207)
Region Coverage: 28.14% (41134/146202)
Branch Coverage: 24.77% (20968/84634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1a2386e155834c696c911ab7082f5e9c3fe52d4e_1a2386e155834c696c911ab7082f5e9c3fe52d4e/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 190643 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1a2386e155834c696c911ab7082f5e9c3fe52d4e, data reload: false

query1	986	398	380	380
query2	6528	2045	2025	2025
query3	6712	213	221	213
query4	34353	23387	23515	23387
query5	4405	480	447	447
query6	267	168	158	158
query7	4620	293	297	293
query8	280	234	222	222
query9	9688	2699	2677	2677
query10	484	268	278	268
query11	18313	15211	15257	15211
query12	157	104	101	101
query13	1615	416	413	413
query14	10706	7398	7512	7398
query15	301	185	178	178
query16	7969	472	474	472
query17	1779	566	555	555
query18	2124	332	316	316
query19	358	147	148	147
query20	117	105	109	105
query21	213	102	105	102
query22	4657	4173	4182	4173
query23	34785	33905	33954	33905
query24	11174	2908	2827	2827
query25	645	399	417	399
query26	1404	163	157	157
query27	2781	293	292	292
query28	8151	2457	2458	2457
query29	924	435	422	422
query30	321	166	155	155
query31	1064	806	819	806
query32	100	54	57	54
query33	774	312	297	297
query34	941	497	483	483
query35	891	722	718	718
query36	1101	956	967	956
query37	163	89	88	88
query38	4016	3904	3852	3852
query39	1459	1417	1401	1401
query40	287	98	98	98
query41	54	46	49	46
query42	118	100	96	96
query43	522	482	457	457
query44	1320	846	806	806
query45	197	167	168	167
query46	1131	764	749	749
query47	1914	1786	1831	1786
query48	457	365	376	365
query49	1153	439	397	397
query50	828	406	408	406
query51	7090	6990	6903	6903
query52	102	90	87	87
query53	256	186	182	182
query54	1185	464	463	463
query55	84	76	81	76
query56	296	261	269	261
query57	1226	1101	1095	1095
query58	250	301	254	254
query59	3142	3157	2854	2854
query60	312	279	272	272
query61	145	105	102	102
query62	871	664	670	664
query63	214	182	190	182
query64	5219	639	627	627
query65	3315	3173	3171	3171
query66	1445	305	300	300
query67	15972	15411	15353	15353
query68	4918	573	570	570
query69	463	286	305	286
query70	1190	1133	1153	1133
query71	348	278	270	270
query72	6400	4009	3966	3966
query73	773	326	329	326
query74	9575	8965	9000	8965
query75	3379	2660	2655	2655
query76	2893	947	937	937
query77	438	282	290	282
query78	9961	9149	9303	9149
query79	2334	550	564	550
query80	1313	434	445	434
query81	540	242	252	242
query82	908	148	139	139
query83	216	135	140	135
query84	236	86	82	82
query85	1310	287	285	285
query86	412	274	301	274
query87	4429	4278	4345	4278
query88	3388	2347	2336	2336
query89	395	284	280	280
query90	2112	185	195	185
query91	174	142	147	142
query92	78	53	48	48
query93	1683	558	543	543
query94	1149	300	299	299
query95	364	260	251	251
query96	620	288	284	284
query97	3221	3097	3095	3095
query98	219	200	203	200
query99	1516	1293	1295	1293
Total cold run time: 303386 ms
Total hot run time: 190643 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1a2386e155834c696c911ab7082f5e9c3fe52d4e, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.03	0.02
query3	0.23	0.06	0.06
query4	1.65	0.10	0.10
query5	0.53	0.51	0.50
query6	1.14	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.49
query10	0.55	0.56	0.55
query11	0.14	0.11	0.11
query12	0.13	0.11	0.11
query13	0.60	0.61	0.58
query14	2.92	2.95	3.05
query15	0.90	0.82	0.82
query16	0.37	0.39	0.39
query17	0.99	0.95	1.07
query18	0.20	0.21	0.20
query19	1.97	1.75	2.00
query20	0.01	0.01	0.01
query21	15.36	0.58	0.58
query22	2.98	1.86	2.10
query23	17.08	0.94	0.76
query24	3.16	0.98	1.26
query25	0.19	0.16	0.09
query26	0.51	0.15	0.13
query27	0.03	0.04	0.04
query28	10.21	1.10	1.08
query29	12.53	3.33	3.28
query30	0.25	0.06	0.06
query31	2.86	0.38	0.38
query32	3.28	0.47	0.46
query33	2.97	2.99	3.03
query34	16.62	4.39	4.39
query35	4.40	4.42	4.41
query36	0.68	0.49	0.47
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.14	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 106.63 s
Total hot run time: 32.65 s

@Mryange
Copy link
Contributor Author

Mryange commented Sep 24, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.27% (9607/25777)
Line Coverage: 28.68% (79504/277222)
Region Coverage: 28.13% (41125/146203)
Branch Coverage: 24.77% (20965/84628)
Coverage Report: http://coverage.selectdb-in.cc/coverage/82af2cd12514b73479cb6630351a5d40a95f1978_82af2cd12514b73479cb6630351a5d40a95f1978/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 42143 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 82af2cd12514b73479cb6630351a5d40a95f1978, data reload: false

------ Round 1 ----------------------------------
q1	17600	7491	7392	7392
q2	2044	300	295	295
q3	12214	1083	1182	1083
q4	10581	695	795	695
q5	7772	3191	3096	3096
q6	238	153	150	150
q7	1032	622	623	622
q8	9451	2091	2043	2043
q9	6806	6422	6468	6422
q10	7028	2297	2309	2297
q11	430	266	256	256
q12	417	226	218	218
q13	17778	3011	3046	3011
q14	252	217	226	217
q15	579	560	518	518
q16	698	633	613	613
q17	992	813	803	803
q18	7402	6819	6903	6819
q19	1401	1031	1083	1031
q20	589	302	281	281
q21	4244	3291	3264	3264
q22	1122	1019	1017	1017
Total cold run time: 110670 ms
Total hot run time: 42143 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7291	7265	7393	7265
q2	345	231	234	231
q3	3149	3060	3035	3035
q4	2077	1818	1880	1818
q5	5742	5637	5746	5637
q6	228	148	150	148
q7	2221	1848	1876	1848
q8	3344	3483	3488	3483
q9	8961	8871	8809	8809
q10	3526	3493	3475	3475
q11	594	479	485	479
q12	832	590	603	590
q13	10124	3195	3190	3190
q14	291	279	292	279
q15	578	525	529	525
q16	738	666	638	638
q17	1995	1634	1617	1617
q18	8653	8357	7870	7870
q19	1750	1681	1704	1681
q20	2153	1880	1852	1852
q21	5600	5440	5450	5440
q22	1122	1017	1031	1017
Total cold run time: 71314 ms
Total hot run time: 60927 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192689 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 82af2cd12514b73479cb6630351a5d40a95f1978, data reload: false

query1	937	398	393	393
query2	6325	2057	2045	2045
query3	8704	194	206	194
query4	33585	23570	23520	23520
query5	3550	487	451	451
query6	280	199	173	173
query7	4194	323	304	304
query8	289	225	228	225
query9	9687	2706	2698	2698
query10	474	289	281	281
query11	18039	15414	15178	15178
query12	155	99	100	99
query13	1535	424	402	402
query14	10025	7445	7569	7445
query15	254	171	183	171
query16	8007	445	493	445
query17	1634	580	573	573
query18	2158	312	323	312
query19	358	146	144	144
query20	123	116	119	116
query21	212	111	104	104
query22	4798	4498	4347	4347
query23	35486	34582	34657	34582
query24	11247	2954	2918	2918
query25	600	376	388	376
query26	1385	163	168	163
query27	2584	281	289	281
query28	7769	2487	2441	2441
query29	924	410	411	410
query30	253	165	160	160
query31	1028	801	804	801
query32	92	53	54	53
query33	731	305	304	304
query34	921	479	499	479
query35	880	727	723	723
query36	1070	952	935	935
query37	157	87	90	87
query38	3972	3924	4002	3924
query39	1479	1406	1455	1406
query40	273	101	101	101
query41	51	51	48	48
query42	116	98	96	96
query43	516	489	478	478
query44	1261	826	815	815
query45	195	169	163	163
query46	1140	751	762	751
query47	1905	1812	1860	1812
query48	470	370	367	367
query49	978	407	409	407
query50	832	413	408	408
query51	6992	6959	6964	6959
query52	105	93	92	92
query53	262	182	181	181
query54	1241	473	481	473
query55	78	76	81	76
query56	295	292	270	270
query57	1206	1118	1094	1094
query58	251	261	247	247
query59	3166	3023	2900	2900
query60	305	278	278	278
query61	126	125	124	124
query62	811	668	658	658
query63	214	188	189	188
query64	5042	732	732	732
query65	3294	3202	3164	3164
query66	1326	313	321	313
query67	16305	15630	15474	15474
query68	4910	589	587	587
query69	596	302	313	302
query70	1132	1128	1127	1127
query71	415	278	281	278
query72	7300	4112	3985	3985
query73	766	329	339	329
query74	10349	9239	9081	9081
query75	3615	2664	2652	2652
query76	3586	990	891	891
query77	493	301	289	289
query78	11522	9821	9422	9422
query79	2093	552	547	547
query80	1056	443	433	433
query81	545	239	242	239
query82	510	152	138	138
query83	312	139	138	138
query84	256	76	81	76
query85	757	292	277	277
query86	477	287	298	287
query87	4528	4387	4332	4332
query88	3321	2319	2348	2319
query89	404	292	281	281
query90	2075	188	187	187
query91	182	141	141	141
query92	62	50	50	50
query93	1377	551	543	543
query94	1018	297	300	297
query95	359	273	262	262
query96	610	277	282	277
query97	3297	3168	3113	3113
query98	223	201	194	194
query99	1504	1283	1295	1283
Total cold run time: 304307 ms
Total hot run time: 192689 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.57 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 82af2cd12514b73479cb6630351a5d40a95f1978, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.65	0.10	0.10
query5	0.51	0.50	0.52
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.52	0.50
query10	0.55	0.57	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.99	2.98	3.03
query15	0.91	0.82	0.82
query16	0.38	0.39	0.37
query17	1.10	1.02	1.06
query18	0.20	0.19	0.18
query19	1.94	1.87	1.97
query20	0.02	0.01	0.01
query21	15.35	0.58	0.58
query22	3.01	2.33	1.47
query23	17.42	0.69	0.79
query24	2.82	0.25	1.31
query25	0.32	0.04	0.19
query26	0.40	0.14	0.13
query27	0.05	0.05	0.04
query28	11.38	1.09	1.07
query29	12.53	3.26	3.23
query30	0.24	0.06	0.05
query31	2.89	0.38	0.37
query32	3.29	0.47	0.47
query33	2.99	3.02	3.06
query34	16.64	4.41	4.38
query35	4.46	4.39	4.43
query36	0.67	0.49	0.50
query37	0.08	0.05	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.15	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 108.14 s
Total hot run time: 31.57 s

@Mryange
Copy link
Contributor Author

Mryange commented Sep 25, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9625/25811)
Line Coverage: 28.70% (79644/277532)
Region Coverage: 28.13% (41189/146445)
Branch Coverage: 24.76% (20979/84738)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4d6af96fa3b5747b3dd4e75269ba2a6c5cbf0788_4d6af96fa3b5747b3dd4e75269ba2a6c5cbf0788/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40950 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d6af96fa3b5747b3dd4e75269ba2a6c5cbf0788, data reload: false

------ Round 1 ----------------------------------
q1	17751	7457	7261	7261
q2	2041	282	278	278
q3	11939	1059	1232	1059
q4	10563	766	847	766
q5	7780	2956	2846	2846
q6	240	150	147	147
q7	967	615	607	607
q8	9360	1956	1988	1956
q9	6572	6465	6436	6436
q10	6988	2360	2332	2332
q11	444	253	251	251
q12	422	220	213	213
q13	17782	2965	2949	2949
q14	250	211	214	211
q15	561	534	524	524
q16	666	611	601	601
q17	981	555	512	512
q18	7361	6658	6751	6658
q19	1399	1078	1018	1018
q20	605	280	279	279
q21	3939	3095	3181	3095
q22	1091	951	1010	951
Total cold run time: 109702 ms
Total hot run time: 40950 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7249	7265	7248	7248
q2	338	239	234	234
q3	3091	2962	2957	2957
q4	2103	1884	1840	1840
q5	5676	5689	5708	5689
q6	230	141	146	141
q7	2242	1800	1809	1800
q8	3386	3549	3582	3549
q9	8893	9119	8971	8971
q10	3617	3535	3597	3535
q11	572	487	501	487
q12	814	600	641	600
q13	9678	3155	3182	3155
q14	308	283	292	283
q15	586	507	530	507
q16	720	670	677	670
q17	1861	1666	1606	1606
q18	8227	7847	7964	7847
q19	1715	1552	1429	1429
q20	2131	1881	1865	1865
q21	5659	5344	5481	5344
q22	1126	1058	1047	1047
Total cold run time: 70222 ms
Total hot run time: 60804 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192604 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4d6af96fa3b5747b3dd4e75269ba2a6c5cbf0788, data reload: false

query1	967	378	399	378
query2	6351	2101	2033	2033
query3	8689	197	205	197
query4	33500	23661	23572	23572
query5	3606	473	498	473
query6	263	166	166	166
query7	4188	313	308	308
query8	273	227	216	216
query9	9473	2719	2708	2708
query10	461	287	285	285
query11	18046	15229	15177	15177
query12	164	100	96	96
query13	1542	434	420	420
query14	9605	6518	7309	6518
query15	256	169	174	169
query16	7937	451	482	451
query17	1719	622	611	611
query18	2124	325	325	325
query19	377	156	155	155
query20	121	121	118	118
query21	213	109	107	107
query22	4873	4620	4532	4532
query23	35375	35348	35150	35150
query24	11159	2889	2835	2835
query25	544	398	432	398
query26	730	176	184	176
query27	2133	297	300	297
query28	7661	2452	2454	2452
query29	668	450	433	433
query30	269	165	158	158
query31	1042	817	791	791
query32	99	56	59	56
query33	764	315	306	306
query34	925	509	502	502
query35	897	742	750	742
query36	1119	924	949	924
query37	154	90	90	90
query38	3993	3936	3889	3889
query39	1499	1444	1424	1424
query40	213	101	103	101
query41	53	52	49	49
query42	119	100	106	100
query43	524	473	479	473
query44	1289	816	814	814
query45	197	167	168	167
query46	1161	717	729	717
query47	1908	1832	1867	1832
query48	480	367	379	367
query49	875	423	409	409
query50	835	431	434	431
query51	7075	7076	6979	6979
query52	100	88	87	87
query53	264	189	190	189
query54	1271	474	491	474
query55	77	80	83	80
query56	304	264	257	257
query57	1230	1083	1134	1083
query58	237	246	230	230
query59	3185	3058	2993	2993
query60	298	278	282	278
query61	105	107	105	105
query62	818	685	664	664
query63	221	196	189	189
query64	3835	677	649	649
query65	3262	3199	3181	3181
query66	763	308	306	306
query67	16105	15578	15585	15578
query68	4947	572	579	572
query69	626	310	352	310
query70	1208	1124	1079	1079
query71	424	293	293	293
query72	7356	4101	3966	3966
query73	763	350	356	350
query74	10710	8977	9116	8977
query75	4067	2682	2645	2645
query76	3637	906	927	906
query77	661	317	298	298
query78	10225	9380	9189	9189
query79	2366	600	608	600
query80	1278	458	449	449
query81	559	250	238	238
query82	600	141	142	141
query83	321	141	147	141
query84	273	80	78	78
query85	1556	289	301	289
query86	617	308	298	298
query87	4405	4316	4381	4316
query88	3953	2435	2387	2387
query89	428	288	285	285
query90	2156	189	190	189
query91	178	147	149	147
query92	67	47	50	47
query93	2280	547	538	538
query94	1075	286	307	286
query95	369	258	275	258
query96	625	278	279	278
query97	3224	3132	3170	3132
query98	234	206	213	206
query99	1563	1325	1296	1296
Total cold run time: 303334 ms
Total hot run time: 192604 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.24 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d6af96fa3b5747b3dd4e75269ba2a6c5cbf0788, data reload: false

query1	0.05	0.04	0.05
query2	0.07	0.03	0.03
query3	0.22	0.06	0.06
query4	1.66	0.10	0.10
query5	0.51	0.52	0.50
query6	1.13	0.73	0.73
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.61	0.59
query14	2.94	2.95	2.98
query15	0.89	0.83	0.83
query16	0.37	0.39	0.38
query17	1.05	1.06	1.05
query18	0.20	0.20	0.20
query19	1.88	1.86	1.98
query20	0.01	0.01	0.00
query21	15.36	0.58	0.59
query22	2.82	2.50	1.57
query23	17.34	0.90	0.85
query24	2.95	0.60	1.47
query25	0.14	0.04	0.11
query26	0.58	0.14	0.13
query27	0.05	0.04	0.04
query28	10.73	1.11	1.06
query29	12.53	3.26	3.24
query30	0.25	0.06	0.06
query31	2.88	0.39	0.37
query32	3.30	0.48	0.46
query33	2.94	2.94	3.07
query34	16.63	4.43	4.46
query35	4.51	4.48	4.46
query36	0.68	0.48	0.51
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.02	0.02	0.02
query40	0.15	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.2 s
Total hot run time: 32.24 s

HappenLee
HappenLee reviewed Sep 27, 2024
View reviewed changes
be/src/pipeline/exec/scan_operator.cpp
@@ -682,7 +684,7 @@ Status ScanLocalState<Derived>::_should_push_down_binary_predicate(
DCHECK(constant_val->data == nullptr) << "constant_val should not have a value";
const auto& children = fn_call->children();
DCHECK(children.size() == 2);
for (size_t i = 0; i < children.size(); i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the code？

@Mryange
Copy link
Contributor Author

Mryange commented Sep 27, 2024

run buildall

@Mryange
Copy link
Contributor Author

Mryange commented Sep 27, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41096 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eed9b4cfe3f1b533a3aff6d562f496844a35a28c, data reload: false

------ Round 1 ----------------------------------
q1	17913	7526	7346	7346
q2	2317	161	154	154
q3	11586	1197	1182	1182
q4	10456	741	749	741
q5	8419	2977	2869	2869
q6	239	148	162	148
q7	979	635	638	635
q8	9602	1945	1972	1945
q9	6594	6405	6400	6400
q10	6948	2277	2333	2277
q11	455	248	255	248
q12	406	213	218	213
q13	17804	2989	2978	2978
q14	240	203	207	203
q15	576	544	527	527
q16	636	586	570	570
q17	994	528	570	528
q18	7379	6757	6775	6757
q19	1399	1073	1053	1053
q20	511	196	213	196
q21	3936	3271	3129	3129
q22	1114	1018	997	997
Total cold run time: 110503 ms
Total hot run time: 41096 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7211	7191	7223	7191
q2	331	227	227	227
q3	2918	2738	2734	2734
q4	1951	1697	1661	1661
q5	5452	5439	5438	5438
q6	238	137	139	137
q7	2110	1721	1693	1693
q8	3277	3404	3412	3404
q9	8536	8501	8575	8501
q10	3453	3456	3451	3451
q11	587	482	472	472
q12	763	576	576	576
q13	5328	2962	3004	2962
q14	288	264	255	255
q15	566	511	519	511
q16	678	647	638	638
q17	1800	1574	1539	1539
q18	7811	7343	7462	7343
q19	1654	1542	1494	1494
q20	2037	1797	1787	1787
q21	5276	5172	5213	5172
q22	1083	968	1009	968
Total cold run time: 63348 ms
Total hot run time: 58154 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191202 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eed9b4cfe3f1b533a3aff6d562f496844a35a28c, data reload: false

query1	1002	375	371	371
query2	6518	2114	2043	2043
query3	6711	208	224	208
query4	33849	23472	23441	23441
query5	4398	462	455	455
query6	259	180	166	166
query7	4627	298	317	298
query8	277	234	218	218
query9	9599	2649	2611	2611
query10	470	283	281	281
query11	17956	15067	15053	15053
query12	162	96	107	96
query13	1639	443	402	402
query14	10302	7260	7207	7207
query15	257	172	179	172
query16	8081	437	481	437
query17	1627	575	563	563
query18	2149	325	320	320
query19	365	151	155	151
query20	118	104	111	104
query21	221	102	115	102
query22	4459	4257	4189	4189
query23	34938	34371	35502	34371
query24	11190	2792	2856	2792
query25	551	404	414	404
query26	866	162	162	162
query27	2828	303	292	292
query28	7840	2450	2430	2430
query29	669	433	437	433
query30	322	158	154	154
query31	1085	805	816	805
query32	98	57	59	57
query33	775	315	298	298
query34	941	498	514	498
query35	916	731	729	729
query36	1104	948	943	943
query37	144	88	90	88
query38	4033	3952	3914	3914
query39	1489	1438	1403	1403
query40	289	100	102	100
query41	51	54	49	49
query42	119	95	96	95
query43	530	473	475	473
query44	1228	818	795	795
query45	199	170	173	170
query46	1143	700	695	695
query47	1927	1784	1824	1784
query48	470	368	369	368
query49	1183	418	408	408
query50	829	403	413	403
query51	7100	6958	6667	6667
query52	100	87	85	85
query53	258	192	183	183
query54	1116	483	478	478
query55	80	79	75	75
query56	286	263	271	263
query57	1223	1102	1108	1102
query58	241	241	251	241
query59	3164	2922	2837	2837
query60	305	282	286	282
query61	127	126	125	125
query62	919	646	684	646
query63	223	191	190	190
query64	4143	643	614	614
query65	3260	3167	3174	3167
query66	950	306	307	306
query67	16045	15408	15689	15408
query68	4878	573	556	556
query69	481	290	307	290
query70	1221	1147	1107	1107
query71	331	267	277	267
query72	6333	4003	3987	3987
query73	765	344	351	344
query74	10256	8943	9072	8943
query75	3405	2649	2673	2649
query76	2887	978	925	925
query77	456	320	319	319
query78	11011	9847	9671	9671
query79	2611	588	614	588
query80	1893	451	441	441
query81	589	239	245	239
query82	749	138	137	137
query83	301	141	135	135
query84	284	80	76	76
query85	1635	306	287	287
query86	495	303	305	303
query87	4457	4322	4315	4315
query88	3852	2401	2344	2344
query89	418	293	311	293
query90	2051	195	195	195
query91	199	142	146	142
query92	69	47	48	47
query93	2341	567	549	549
query94	1067	291	303	291
query95	362	256	251	251
query96	626	278	287	278
query97	3241	3107	3085	3085
query98	224	202	197	197
query99	1569	1304	1281	1281
Total cold run time: 303400 ms
Total hot run time: 191202 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9627/25814)
Line Coverage: 28.70% (79666/277626)
Region Coverage: 28.13% (41199/146446)
Branch Coverage: 24.75% (20978/84750)
Coverage Report: http://coverage.selectdb-in.cc/coverage/eed9b4cfe3f1b533a3aff6d562f496844a35a28c_eed9b4cfe3f1b533a3aff6d562f496844a35a28c/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 33.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eed9b4cfe3f1b533a3aff6d562f496844a35a28c, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.03	0.03
query3	0.24	0.06	0.06
query4	1.65	0.10	0.10
query5	0.52	0.50	0.51
query6	1.13	0.73	0.71
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.51
query10	0.58	0.58	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.60	0.60	0.60
query14	2.80	2.71	2.80
query15	0.88	0.81	0.83
query16	0.40	0.39	0.38
query17	1.04	1.02	1.06
query18	0.23	0.21	0.21
query19	1.92	1.86	2.01
query20	0.01	0.02	0.01
query21	15.36	0.59	0.57
query22	2.92	2.28	2.66
query23	17.03	0.95	0.77
query24	2.92	1.06	1.16
query25	0.25	0.17	0.13
query26	0.37	0.14	0.15
query27	0.06	0.04	0.04
query28	10.66	1.10	1.06
query29	12.56	3.27	3.26
query30	0.25	0.06	0.06
query31	2.88	0.39	0.37
query32	3.27	0.47	0.46
query33	2.99	3.01	3.03
query34	17.22	4.46	4.51
query35	4.49	4.56	4.50
query36	0.67	0.48	0.48
query37	0.08	0.05	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.38 s
Total hot run time: 33.26 s

@Mryange
Copy link
Contributor Author

Mryange commented Sep 27, 2024

run cloud_p0

@Mryange
Copy link
Contributor Author

Mryange commented Sep 28, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9627/25814)
Line Coverage: 28.70% (79707/277679)
Region Coverage: 28.13% (41207/146490)
Branch Coverage: 24.75% (20984/84790)
Coverage Report: http://coverage.selectdb-in.cc/coverage/eed9b4cfe3f1b533a3aff6d562f496844a35a28c_eed9b4cfe3f1b533a3aff6d562f496844a35a28c/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40917 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eed9b4cfe3f1b533a3aff6d562f496844a35a28c, data reload: false

------ Round 1 ----------------------------------
q1	17584	7498	7372	7372
q2	2016	279	273	273
q3	12083	1067	1268	1067
q4	10533	797	763	763
q5	7761	2932	2854	2854
q6	248	147	146	146
q7	966	624	634	624
q8	9362	1930	1950	1930
q9	6536	6452	6404	6404
q10	6946	2291	2302	2291
q11	451	238	241	238
q12	423	222	221	221
q13	17775	2957	2993	2957
q14	249	218	209	209
q15	578	516	514	514
q16	689	578	610	578
q17	977	591	541	541
q18	7207	6740	6568	6568
q19	1391	954	1055	954
q20	490	224	208	208
q21	3982	3264	3227	3227
q22	1103	1004	978	978
Total cold run time: 109350 ms
Total hot run time: 40917 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7234	7243	7267	7243
q2	333	231	231	231
q3	3019	2917	3008	2917
q4	2104	1854	1799	1799
q5	5728	5792	5769	5769
q6	234	144	142	142
q7	2265	1837	1840	1837
q8	3425	3540	3449	3449
q9	8974	8968	8866	8866
q10	3618	3500	3555	3500
q11	615	498	494	494
q12	846	640	591	591
q13	9685	3198	3176	3176
q14	329	271	294	271
q15	577	527	504	504
q16	682	641	681	641
q17	1825	1616	1580	1580
q18	8290	7708	7645	7645
q19	1706	1421	1347	1347
q20	2129	1849	1851	1849
q21	5534	5536	5504	5504
q22	1158	1103	1057	1057
Total cold run time: 70310 ms
Total hot run time: 60412 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191242 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eed9b4cfe3f1b533a3aff6d562f496844a35a28c, data reload: false

query1	903	396	425	396
query2	6235	2142	2035	2035
query3	8682	196	201	196
query4	33770	23703	23354	23354
query5	3412	486	474	474
query6	271	168	173	168
query7	4190	307	312	307
query8	294	227	241	227
query9	9647	2696	2706	2696
query10	462	276	278	276
query11	17741	15128	15256	15128
query12	156	101	95	95
query13	1526	425	405	405
query14	9865	7664	6753	6753
query15	287	181	190	181
query16	7405	459	443	443
query17	1757	617	586	586
query18	2007	332	322	322
query19	362	156	155	155
query20	121	116	117	116
query21	226	117	102	102
query22	4945	4756	4536	4536
query23	35106	34238	33968	33968
query24	11057	2822	2846	2822
query25	612	443	413	413
query26	1051	161	163	161
query27	2478	295	297	295
query28	7459	2438	2424	2424
query29	780	445	439	439
query30	268	156	154	154
query31	1008	813	799	799
query32	99	54	59	54
query33	765	292	299	292
query34	911	489	487	487
query35	900	711	723	711
query36	1087	960	950	950
query37	148	90	92	90
query38	4171	3942	3884	3884
query39	1463	1420	1429	1420
query40	205	96	98	96
query41	50	47	50	47
query42	114	94	94	94
query43	544	497	499	497
query44	1174	817	799	799
query45	207	168	165	165
query46	1148	714	709	709
query47	1928	1829	1850	1829
query48	448	377	371	371
query49	897	411	401	401
query50	832	409	399	399
query51	7151	7009	6985	6985
query52	102	88	90	88
query53	257	178	204	178
query54	1224	460	486	460
query55	77	75	77	75
query56	268	253	238	238
query57	1248	1124	1095	1095
query58	233	222	234	222
query59	3159	2873	2849	2849
query60	292	258	262	258
query61	104	101	107	101
query62	859	682	675	675
query63	216	202	188	188
query64	4608	645	607	607
query65	3531	3169	3222	3169
query66	1396	299	332	299
query67	15991	15551	15766	15551
query68	4537	573	555	555
query69	511	303	284	284
query70	1181	1061	1059	1059
query71	365	274	273	273
query72	7218	3972	4092	3972
query73	756	344	341	341
query74	10287	9094	9060	9060
query75	3408	2652	2665	2652
query76	3013	884	938	884
query77	598	292	293	292
query78	10461	9628	9552	9552
query79	2732	597	600	597
query80	2503	442	455	442
query81	584	237	239	237
query82	693	143	136	136
query83	300	135	134	134
query84	277	74	77	74
query85	1615	300	293	293
query86	412	301	293	293
query87	4542	4330	4393	4330
query88	3472	2406	2370	2370
query89	400	286	284	284
query90	2010	185	189	185
query91	184	141	145	141
query92	58	48	51	48
query93	2039	556	552	552
query94	1101	295	301	295
query95	364	259	247	247
query96	616	278	278	278
query97	3239	3151	3164	3151
query98	222	205	191	191
query99	1525	1329	1281	1281
Total cold run time: 303113 ms
Total hot run time: 191242 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eed9b4cfe3f1b533a3aff6d562f496844a35a28c, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.03	0.03
query3	0.24	0.06	0.06
query4	1.64	0.10	0.10
query5	0.51	0.51	0.52
query6	1.14	0.72	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.48
query10	0.55	0.55	0.56
query11	0.14	0.11	0.11
query12	0.13	0.11	0.11
query13	0.61	0.59	0.60
query14	2.72	2.83	2.76
query15	0.89	0.83	0.82
query16	0.39	0.41	0.37
query17	1.10	1.08	1.08
query18	0.20	0.19	0.19
query19	1.99	1.77	2.03
query20	0.01	0.01	0.01
query21	15.35	0.61	0.60
query22	2.41	2.85	1.77
query23	17.03	0.93	0.76
query24	2.95	0.66	0.90
query25	0.22	0.08	0.19
query26	0.27	0.15	0.14
query27	0.04	0.04	0.05
query28	11.18	1.10	1.07
query29	12.60	3.26	3.26
query30	0.25	0.06	0.06
query31	2.86	0.37	0.39
query32	3.28	0.47	0.45
query33	3.02	3.04	3.09
query34	17.15	4.42	4.46
query35	4.51	4.51	4.54
query36	0.67	0.48	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.15	0.12	0.12
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 107.21 s
Total hot run time: 32.34 s

HappenLee
HappenLee approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit 9bd671f into apache:master Sep 29, 2024
23 of 28 checks passed
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@Mryange @cjj2010
[chore](check) open shorten-64-to-32 error (apache#41197)
5f92ea5 
```
doris/be/src/pipeline/pipeline_fragment_context.cpp:1160:76: error: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
 1159 |         _sink.reset(new MultiCastDataStreamSinkOperatorX(
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1160 |                 sink_id, sources, thrift_sink.multi_cast_stream_sink.sinks.size(), pool,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
```
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@Mryange @amorynan
[chore](check) open shorten-64-to-32 error (apache#41197)
48b7b6a 
```
doris/be/src/pipeline/pipeline_fragment_context.cpp:1160:76: error: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
 1159 |         _sink.reset(new MultiCastDataStreamSinkOperatorX(
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1160 |                 sink_id, sources, thrift_sink.multi_cast_stream_sink.sinks.size(), pool,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mryange @doris-robot @HappenLee @zhangstar333