Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image.registry not being respect #1282

Closed
2 tasks done
zyue110026 opened this issue Aug 8, 2024 · 0 comments · Fixed by #1283
Closed
2 tasks done

image.registry not being respect #1282

zyue110026 opened this issue Aug 8, 2024 · 0 comments · Fixed by #1283

Comments

@zyue110026
Copy link
Contributor

We have noticed an instance of incorrect helming in one of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

image.registry does not take effect when changed to a value other than default value 'docker.io'. This is due to missing implementation for this value in helm charts deploy.yaml file:

image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.Version }}"

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the REAMDE of this repository and believe that this is not a duplicate.

Environment

  • Dubbo Admin version: main
  • Registry center detail (type and version): xxx
  • Operating System version: xxx
  • Java version: xxx

Steps to reproduce this issue

  1. change the value of image.registry in values.yaml file
  2. using helm chart to deploy

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

change image.registry can take affect, or delete image.registry from values.yaml file

Actual Result

image.registry always be 'docker.io'

If there is an exception, please attach the exception trace:

Just put your stack trace here!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant