Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codecov configuration] PR failing if test coverage went down #1638

Closed
htynkn opened this issue Apr 19, 2018 · 1 comment
Closed

[Codecov configuration] PR failing if test coverage went down #1638

htynkn opened this issue Apr 19, 2018 · 1 comment

Comments

@htynkn
Copy link
Member

htynkn commented Apr 19, 2018

As discuss in mail list: https://lists.apache.org/thread.html/cf55ed71de3ebeaa7db3a6a81ee1a6dc86ceeac2c2b185ea56e6391d@%3Cdev.dubbo.apache.org%3E

For pull request, we ask every pull request has necessary unit test.
Codecov has a feature to fail PR if test coverage went down. Which means for any pull request, if it add some code without any unit test, the PR will fail.
This can help to increase test coverage.

Considering tiny change, we need a threshold value which allow the coverage to drop by X%, and posting a success status. Please find more detail in mail list link

Related links:
https://docs.codecov.io/docs/commit-status
https://github.com/codecov/support/issues/351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants