Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForkingClusterInvoker missing RpcContext and the attachments. #2023

Closed
2 tasks done
carryxyh opened this issue Jul 4, 2018 · 1 comment
Closed
2 tasks done

ForkingClusterInvoker missing RpcContext and the attachments. #2023

carryxyh opened this issue Jul 4, 2018 · 1 comment
Labels
type/need-triage Need maintainers to triage
Milestone

Comments

@carryxyh
Copy link
Member

carryxyh commented Jul 4, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.0-SNAPSHOT
  • Operating System version: mac os
  • Java version: 1.8

Step to reproduce this issue

  1. Export a service
  2. Make cluster = "forking"
  3. Set Attachment in RpcContext
  4. Do rpc invoke

Expected Result

The attachment in RpcContext has element.

Actual Result

The attachment in RpcContext don't have element.

The problem

I set attachment in the consumer side like this:
image

Then do rpc invoke,but the attachment is missing, (AbstractInvoker#invoke):
image

The problem is that ForkingClusterInvoker use threapool to do rpc invoke which will miss the threadlocal:
image

@carryxyh
Copy link
Member Author

carryxyh commented Aug 6, 2018

This issue has been fixed by #2024.
Close this one.

@carryxyh carryxyh closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/need-triage Need maintainers to triage
Projects
None yet
Development

No branches or pull requests

2 participants