Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] Dubbo support Google Protobuf generic reference#PR:3825 #3829

Closed
vio-lin opened this issue Apr 8, 2019 · 0 comments
Closed

[DISCUSS] Dubbo support Google Protobuf generic reference#PR:3825 #3829

vio-lin opened this issue Apr 8, 2019 · 0 comments
Milestone

Comments

@vio-lin
Copy link
Contributor

vio-lin commented Apr 8, 2019

support Google Pb generic invocation

purpos

Currently, Generic Reference cannot support Google Protobuf. With bride usage of Google PB, we are going to support it via Generic Reference.

problem

Google protobuf entity generated by builder. It can't be created by generic filter.

Util Used

There are some project can convert json and google protobuf entity java-protobuf-util .

how to invoke service

  1. build serviceDefinition metadata of protobuf service. We can build typeDefinition by parsing methods of Innner Builder of entity.
  2. client generates json string by service metadata.
  3. modify generic filter in provider to support serialize json to Pb object.
  4. add ProtobufUtil.class to serialize /deserialize Google Protobuf Object

feedback wanted

To support Google PB Testing, GenericFilter is part of my change, also Service Metadata have to support that. I want to know if it is gracefull enough to solve this problem.

@vio-lin vio-lin changed the title [DISCUSS] Dubbo support Google Protobuf generic reference [DISCUSS] Dubbo support Google Protobuf generic reference#PR:3825 Apr 23, 2019
@beiwei30 beiwei30 added this to the 2.7.2 milestone May 8, 2019
@beiwei30 beiwei30 closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants