Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tuning for TimeoutTask in DefaultFuture #4129

Merged
merged 6 commits into from
May 23, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

manually merge #4085 and #4087

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj requested a review from carryxyh May 23, 2019 05:18
Copy link
Member

@carryxyh carryxyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

@chickenlj chickenlj added this to the 2.7.2 milestone May 23, 2019
@chickenlj chickenlj mentioned this pull request May 23, 2019
6 tasks
@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #4129 into master will decrease coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4129      +/-   ##
============================================
- Coverage     62.75%   62.73%   -0.03%     
  Complexity      475      475              
============================================
  Files           766      766              
  Lines         32887    32888       +1     
  Branches       5189     5189              
============================================
- Hits          20637    20631       -6     
- Misses         9860     9865       +5     
- Partials       2390     2392       +2
Impacted Files Coverage Δ Complexity Δ
...dubbo/remoting/exchange/support/DefaultFuture.java 85.41% <91.66%> (+0.15%) 0 <0> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-1.54%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.79% <0%> (-0.69%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.7% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 78.94% <0%> (+5.26%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5285952...85e91dc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants