Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(candlestick): provide borderColorDoji option for custom doji color #17717

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Sep 29, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Provide option series-candlestick.itemStyle.borderColorDoji to set custom doji color.

Fixed issues

#11042

Details

Before: What was the problem?

Doji means the open and close value of a data item is the same. Previously, it can either be borderColor or borderColor0 according to the previous data item. But if developers want to change it to a custom color, like a neutral colour like gary, it cannot be done.

After: How does it behave after the fixing?

So in this PR, we provide a new option borderColorDoji. If it is set, this color is used for all doji data items.

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

test/candlestick-doji.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Sep 29, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.4.1 milestone Sep 29, 2022
@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. and removed PR: doc ready labels Sep 29, 2022
@echarts-bot
Copy link

echarts-bot bot commented Sep 29, 2022

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@pissang
Copy link
Contributor

pissang commented Oct 16, 2022

Looks great! I'm not famaliar with the term doji, should we also provide colorDoji?

@Ovilia
Copy link
Contributor Author

Ovilia commented Oct 17, 2022

@pissang Doji means the shape is like a cross (十) so there should be no filling color. So I believe colorDoji is not necessary. Thanks!

@pissang
Copy link
Contributor

pissang commented Oct 17, 2022

Thanks for the explaination

@Ovilia Ovilia merged commit 004c3fa into master Oct 17, 2022
@Ovilia Ovilia deleted the fix-11042 branch October 17, 2022 02:31
@echarts-bot
Copy link

echarts-bot bot commented Oct 17, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Ovilia added a commit to apache/echarts-doc that referenced this pull request Dec 1, 2022
@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Dec 1, 2022
Ovilia added a commit to apache/echarts-doc that referenced this pull request Dec 1, 2022
feat(candlestick): add doc for borderColorDoji apache/echarts#17717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants