Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): fix treePathInfo is missing in the type of sunburst formatter callback #18310

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  • fix treePathInfo is missing in the type of formatter callback
  • add missing type definition for the data option

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

const option: echarts.EChartsOption = {
    series: [{
        type: 'sunburst',
        levels: [
            {
                label: {
                    formatter(p) {
                        const { treePathInfo } = params
                        return ''
                    }
                }
            }
        ],
        label: {
            formatter(params) {
                const { treePathInfo } = params
                return ''
            }
        },
        data: [
            {
                label: {
                    formatter(params) {
                        const { treePathInfo } = params
                        return ''
                    }
                }
            }
        ]
    }]
};

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

…atter callback & add missing type definition for the `data` option
@echarts-bot
Copy link

echarts-bot bot commented Feb 25, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you have tested this. :)

@Ovilia Ovilia modified the milestones: 5.5.0, 5.4.2 Mar 3, 2023
@plainheart plainheart merged commit 9c743be into master Mar 5, 2023
@plainheart plainheart deleted the fix/sunburst-types branch March 5, 2023 21:41
@echarts-bot
Copy link

echarts-bot bot commented Mar 5, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] TreePathInfo property of sunburst chart label formatter params could be adopt by document and TS
2 participants