-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pictorialBar): support clip for pictorialBar series #19197
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19197@71799e9 |
@linghaoSu Thanks for correcting. I think this is not ideal. I will try to fix this. |
@linghaoSu It seems that if the clipPath is added on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about preventing the label from being clipped by setting the label ignoreClip
to be true
?
Thanks for the hint! It's a good idea. @linghaoSu @plainheart Please help review again. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Support clip for pictorialBar series.
Fixed issues
#19173
Details
Before: What was the problem?
Pictorial bars may overflow the grid area.
After: How does it behave after the fixing?
User can set
series.clip: true
to enable clipping.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information