Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] change the null reference to empty object in UrlMappingPattern.java #4136

Closed
1 of 2 tasks
nikam14 opened this issue Jun 19, 2023 · 3 comments · May be fixed by #4846
Closed
1 of 2 tasks

[Enhancement] change the null reference to empty object in UrlMappingPattern.java #4136

nikam14 opened this issue Jun 19, 2023 · 3 comments · May be fixed by #4846
Assignees
@heliang666s
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@nikam14
Copy link
Contributor

nikam14 commented Jun 19, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Null is a reference that does not point to any object.
returning an empty object can help to improve the readability and maintainability of code

Describe the solution you'd like

location - eventmesh-admin/eventmesh-admin-rocketmq/src/main/java/org/apache/eventmesh/admin/rocketmq/util/UrlMappingPattern.java
line - 63
expected-
1

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@nikam14 nikam14 added the enhancement New feature or request label Jun 19, 2023
@github-actions github-actions bot added the Stale label Apr 10, 2024
@Pil0tXia Pil0tXia added good first issue Issues for first-time contributors and removed Stale labels Apr 11, 2024
@apache apache deleted a comment from github-actions bot Apr 11, 2024
@Pil0tXia Pil0tXia mentioned this issue Apr 11, 2024
Open
@heliang666s
Copy link

hello,I am new in there,I will try it,please assign me,thanks~

@Pil0tXia
Copy link
Member

@heliang666s Welcome! This issue is open for contribution.

@xwm1992 xwm1992 mentioned this issue Apr 22, 2024
Open
@Pil0tXia
Copy link
Member

Closed according to #4846 (comment).

@Pil0tXia Pil0tXia closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heliang666s heliang666s

Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
3 participants
@Pil0tXia @nikam14 @heliang666s