Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Test] Add unit test for eventmesh-connector-file module #4642

Open
2 of 3 tasks
VishalMCF opened this issue Dec 13, 2023 · 7 comments
Open
2 of 3 tasks

[Unit Test] Add unit test for eventmesh-connector-file module #4642

VishalMCF opened this issue Dec 13, 2023 · 7 comments
Assignees
Labels
good first issue Issues for first-time contributors Stale testing

Comments

@VishalMCF
Copy link
Contributor

VishalMCF commented Dec 13, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Read the unit testing guidelines

  • I have read.

Unit test request

Add unit test for the FileSourceConnector and FileSinkConnector classes.

Describe the unit tests you want to do

Add unit test for the FileSourceConnector and FileSinkConnector classes.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Divyansh200102
Copy link

Can I submit a pr for this? @VishalMCF

@VishalMCF
Copy link
Contributor Author

@Divyansh200102 Sure please go ahead. But make sure that the core logic in File Connector has been implemented. Last time I checked there were issues in the PR. Not sure if they have been merged or not.

@pandaapo
Copy link
Member

@Divyansh200102 Sure please go ahead. But make sure that the core logic in File Connector has been implemented. Last time I checked there were issues in the PR. Not sure if they have been merged or not.

@Divyansh200102 You can add unit test for FileSinkConnector freely. The unit test for FileSourceConnector is being added by other developer.

Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label Jul 18, 2024
@melisolmez
Copy link
Contributor

Hello, Can I work on this issue ?

@github-actions github-actions bot removed the Stale label Sep 12, 2024
Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues for first-time contributors Stale testing
Projects
None yet
Development

No branches or pull requests

5 participants