Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Test] Update Unit tests for eventmesh-runtime admin endpoints #4815

Open
2 of 3 tasks
Pil0tXia opened this issue Apr 6, 2024 · 4 comments
Open
2 of 3 tasks
Assignees
Labels
good first issue Issues for first-time contributors help wanted Extra attention is needed testing

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 6, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Read the unit testing guidelines

  • I have read.

Unit test request

As a result of the refactoring of #4768, all of the unit test classes no longer work and need to be rewritten using Netty.

Describe the unit tests you want to do

Module name: eventmesh-runtime
Located at: org.apache.eventmesh.runtime.admin.handler
Task status: ×(unfinished)

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zzzk1
Copy link

zzzk1 commented May 2, 2024

Hi @Pil0tXia, i want to try this as my first issue

@Pil0tXia
Copy link
Member Author

Pil0tXia commented May 2, 2024

@zzzk1 Welcome to Apache EventMesh community!

@zzzk1
Copy link

zzzk1 commented May 3, 2024

Hi, @Pil0tXia. In #4768, there are three test cases that have been deleted, and I noticed 2 things.

  • eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/admin/handler/EventHandlerTest.java are using Netty directly.
  • This issue requires me to use Netty to support the deletion of those three test cases.

Am I understanding correctly?

@Pil0tXia
Copy link
Member Author

Pil0tXia commented May 3, 2024

@zzzk1 You can write unit tests on a case-by-case basis without specifically using Netty only for all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues for first-time contributors help wanted Extra attention is needed testing
Projects
None yet
Development

No branches or pull requests

2 participants