Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HUDI-7429] Fixing average record size estimation for delta commits #10763

Merged
merged 7 commits into from
May 14, 2024
Merged

[HUDI-7429] Fixing average record size estimation for delta commits #10763

merged 7 commits into from
May 14, 2024

Conversation

nsivabalan
Copy link
Contributor

Change Logs

Avg record size calculation only considers COMMIT actions for now. Fixing it to include replace commits and delta commits as well.

Impact

Fixing avg record size estimation for delta commits and replace commits.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Feb 28, 2024
@danny0405 danny0405 mentioned this pull request Mar 12, 2024
Closed
4 tasks
bvaradar
bvaradar approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nsivabalan nsivabalan force-pushed the avgRecSizeEstimate branch 2 times, most recently from 9a575fe to 34ffbbc Compare May 9, 2024 21:09
@yihua yihua assigned yihua, jonvex and codope and unassigned yihua May 14, 2024
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit c8dec0e into apache:master May 14, 2024
45 of 46 checks passed
yihua added a commit that referenced this pull request May 15, 2024
@nsivabalan @yihua
[HUDI-7429] Fixing average record size estimation for delta commits (#…
6d5e969 
…10763)

Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
Co-authored-by: Jonathan Vexler <=>
yihua added a commit that referenced this pull request May 15, 2024
@nsivabalan @yihua
[HUDI-7429] Fixing average record size estimation for delta commits (#…
2fbb1fc 
…10763)

Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
Co-authored-by: Jonathan Vexler <=>
yihua added a commit that referenced this pull request May 15, 2024
@nsivabalan @yihua
[HUDI-7429] Fixing average record size estimation for delta commits (#…
f746712 
…10763)

Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
Co-authored-by: Jonathan Vexler <=>
@haoxie-aws
Copy link

Hello, replacecommit is excluded from average record size estimation because it has higher compression ratio and can make the average record size underestimated for commits which then cause out of memory issue. Ref: #5939 and #6864.

Is there a reason why we think including replacecommit in the estimation is safe now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-other-tim-brown the-other-tim-brown the-other-tim-brown requested changes

@vinishjail97 vinishjail97 vinishjail97 approved these changes

@bvaradar bvaradar bvaradar approved these changes

@yihua yihua yihua approved these changes

Assignees

@codope codope

@jonvex jonvex

Labels
release-0.15.0 size:L PR with lines of changes in (300, 1000]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nsivabalan @hudi-bot @haoxie-aws @the-other-tim-brown @yihua @bvaradar @vinishjail97 @codope @jonvex