Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct names in the ManifestList #354

Closed
Fokko opened this issue Apr 25, 2024 · 4 comments
Closed

Correct names in the ManifestList #354

Fokko opened this issue Apr 25, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Fokko
Copy link
Contributor

Fokko commented Apr 25, 2024

Looking at the manifest list, we see the following names:

  {
    "name" : "added_data_files_count",
    "type" : "int"
  }, {
    "name" : "existing_data_files_count",
    "type" : "int"
  }, {
    "name" : "deleted_data_files_count",
    "type" : "int"
  }

With the V2 spec the names have been changed:

image

This is just cosmetic, since the fields are looked up by ID, but would be nice to fix this to avoid any future confusion.

@s-akhtar-baig
Copy link
Contributor

@Fokko, can you please assign this to me? Thanks!

@liurenjie1024
Copy link
Contributor

@Fokko, can you please assign this to me? Thanks!

Done, thanks!

@gupteaj
Copy link
Contributor

gupteaj commented May 24, 2024

PR : #380

@liurenjie1024
Copy link
Contributor

Close by #380 Thanks @gupteaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants