Should we use to_avro instead of RawLiteral indirection layer

[ZENOTME]

BTW, why to we need the RawLiteral indirection layer, instead of having sth like

impl Literal {
	fn to_avro(&self) -> avro::Value {...}
}

Originally posted by @xxchan in #456 (comment)

[ZENOTME]

Using RawLiteral as an indirection layer to convert iceberg value to Avro value is not convenient, we should infer how to convert from looking at how Avro Serializer works. I'm reflecting on why we don't use fn to_avro(&self) -> avro::Value {...} directly.🤔 cc @liurenjie1024 @Xuanwo @Fokko

[liurenjie1024]

I think the original motivation of this indirection layer is to build a middle layer for all kinds of format, including json, binary and avro. But it seems that this is not working well as expected. I'm +1 for have different serializer for different formats, since they already have a middle layer such as avro::Value, json::Value, and it would not introduce much burden to us.

[Xuanwo]

Agreed. By the way, will this change introduce extra cost?

[liurenjie1024]

Agreed. By the way, will this change introduce extra cost?

What kind of cost do you mean?

[Xuanwo]

What kind of cost do you mean?

I'm not sure if I understand correctly:

Literal -> Bytes vs Literal -> avro::Value -> Bytes

[xxchan]

I think it's

Literal -> RawLiteral -> Bytes vs Literal -> avro::Value -> Bytes

[Xuanwo]

I think it's

Literal -> RawLiteral -> Bytes vs Literal -> avro::Value -> Bytes

I see. Thanks!