Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Replace binary avro file by generating it on the fly. #70

Closed
liurenjie1024 opened this issue Sep 27, 2023 · 6 comments · Fixed by #118
Closed

test: Replace binary avro file by generating it on the fly. #70

liurenjie1024 opened this issue Sep 27, 2023 · 6 comments · Fixed by #118
Assignees
@liurenjie1024
Labels
good first issue Good for newcomers

Comments

@liurenjie1024
Copy link
Contributor 

          I think it is worth the effort to generate the files. This way we can also generate the whole structure later on (manifest-list, manifest, datafile). Since Iceberg requires absolute paths, it is not easy to generate these files on forehand (looking at the Windows CI 😁)

Originally posted by @Fokko in #56 (comment)
@liurenjie1024 liurenjie1024 mentioned this issue Sep 27, 2023
Merged
@barronw
Copy link
Contributor

barronw commented Sep 29, 2023

Hi @liurenjie1024. Can I work on this issue?

@liurenjie1024
Copy link
Contributor Author

Hi @liurenjie1024. Can I work on this issue?

Yes, sure. Thanks!

@liurenjie1024 liurenjie1024 added the good first issue Good for newcomers label Nov 13, 2023
@ZENOTME ZENOTME mentioned this issue Nov 30, 2023
Merged
@liurenjie1024
Copy link
Contributor Author

cc @barronw Are you still interested in this?

@barronw
Copy link
Contributor

barronw commented Dec 12, 2023 •
edited
Loading

cc @barronw Are you still interested in this?

Hi! I can get a pull request out this week. If someone else wants to work on it in the meantime, feel free!

@liurenjie1024
Copy link
Contributor Author

cc @barronw Are you still interested in this?

Hi! I can get a pull request out this week. If someone else wants to work on it in the meantime, feel free!

This is a blocker of our first release, so I will take this so that our release is not blocked.

@liurenjie1024 liurenjie1024 mentioned this issue Dec 13, 2023
Merged
@liurenjie1024 liurenjie1024 self-assigned this Dec 13, 2023
@Fokko
Copy link
Contributor

Fokko commented Dec 13, 2023

I would love to see this before the release, there is also some interesting data here: #79 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liurenjie1024 liurenjie1024

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Remove binary manifest list avro file liurenjie1024/iceberg-rust
3 participants
@Fokko @liurenjie1024 @barronw