Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to append delete type data file #798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Dec 13, 2024

This PR support to support to append delete type data file

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Dec 13, 2024

cc @liurenjie1024 @Xuanwo @Fokko @sdd

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Dec 14, 2024

Sorry, I think I have some misunderstanding here since the action which support to append data file and delete file(position delete file, equality delete file) is RowDelta.🤔 So I guess what we need is right:

  1. MergingSnapshotProducer: https://github.com/apache/iceberg/blob/540d6a6251e31b232fe6ed2413680621454d107a/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L61
  2. RowDelta: https://github.com/apache/iceberg/blob/540d6a6251e31b232fe6ed2413680621454d107a/api/src/main/java/org/apache/iceberg/RowDelta.java#L32

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Dec 14, 2024

I noticed that MergingSnapshotProducer work like the MergeAppend, it will merge manifest when commit. Is that necessary for RowDelta?🤔 Can we implement RowDelta works like FastAppend but it can append data file and delete type file first here? I trying a demo using this way and it can query using spark. @Fokko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant