Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support consumer bind plugins. #544

Merged
merged 22 commits into from
Sep 21, 2019
Merged

feature: support consumer bind plugins. #544

merged 22 commits into from
Sep 21, 2019

Conversation

membphis
Copy link
Member

@membphis membphis commented Sep 18, 2019 •
edited
Loading

  • test

  • doc

@membphis membphis marked this pull request as ready for review September 21, 2019 00:42
@membphis membphis added this to the ver 0.8 milestone Sep 21, 2019
juzhiyuan
juzhiyuan reviewed Sep 21, 2019
View reviewed changes
doc/architecture-design-cn.md Outdated
@@ -369,20 +369,72 @@ APISIX 区别于其他 API 网关的一大特点是允许用户选择不同 Rout

如上图所示，作为 API 网关，需要知道 API Consumer（消费方）具体是谁，这样就可以对不同 API Consumer 配置不同规则。

|字段|可选|说明|
|---|----|----|
|username|必选|Consumer 名称。|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议修改为 必选：是/否

Copy link
Member Author

@membphis membphis Sep 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, fix later

juzhiyuan
juzhiyuan reviewed Sep 21, 2019
View reviewed changes
doc/architecture-design-cn.md Outdated
如何对某个 Consumer 开启指定插件，可以看下面例子：

```shell
# 创建 Consumer ，指定认证插件 key-auth ,并开启特定插件 limit-count
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应使用中文逗号

lua/apisix/plugin.lua Outdated


function _M.merge_consumer_route(route_conf, consumer_conf)
core.log.info("route conf : ", core.json.delay_encode(route_conf))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议统一 log 内容中的空格

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juzhiyuan good catch, and please use English, thx

@membphis membphis merged commit de3c95d into apache:master Sep 21, 2019
@membphis membphis deleted the consumer-bind-plugin branch September 22, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming left review comments

@juzhiyuan juzhiyuan juzhiyuan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ver 0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@membphis @juzhiyuan @moonming